Skip to content

Retries NPM installation a couple times to prevent network timeouts#13831

Merged
alecslupu merged 3 commits intodevelopfrom
test/flaky-npm-install
Jan 14, 2025
Merged

Retries NPM installation a couple times to prevent network timeouts#13831
alecslupu merged 3 commits intodevelopfrom
test/flaky-npm-install

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

Lately we've seen some flaky related to NPM installation in CI.

This is the stacktrace:

      create  bin/shakapacker
      create  bin/shakapacker-dev-server
      create  bin/yarn
      create  package.json
npm ERR! code ECONNRESET
npm ERR! errno ECONNRESET
npm ERR! network Invalid response body while trying to fetch https://registry.npmjs.org/@tiptap%2fstarter-kit: aborted
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network 
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

npm ERR! A complete log of this run can be found in: /home/runner/.npm/_logs/2025-01-10T11_09_24_649Z-debug-0.log

== Command npm i --save-prod ./packages/browserslist-config ./packages/core ./packages/webpacker failed ==
Error: Process completed with exit code 1.

📌 Related Issues

Testing

As the problem is on the build install script (used by most of the other workflows), and the culprit is random network problems, should just retry those random workflows to see if they happen again.

♥️ Thank you!

@andreslucena andreslucena added flaky spec type: fix PRs that implement a fix for a bug labels Jan 10, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 10, 2025
@andreslucena andreslucena marked this pull request as draft January 10, 2025 12:47
github-actions[bot]
github-actions bot previously approved these changes Jan 13, 2025
@andreslucena andreslucena marked this pull request as ready for review January 14, 2025 09:00
@andreslucena
Copy link
Copy Markdown
Member Author

@alecslupu I rerun the "Build test app" in all the workflows, and specially in the first ones (the one that start with "A" and "B", like "API", "Admin", "AI", "Accountability", "Budgets", "Blogs"). I could not reproduce the network timeout.

As it is almost impossible to reproduce this, I think we should follow the strategy of "just merge it and monitor manually the next couple weeks in develop to see what happens" 😅

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I am prepared!
Popcorn

@alecslupu alecslupu added release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 and removed release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 labels Jan 14, 2025
@alecslupu alecslupu merged commit 18869cf into develop Jan 14, 2025
@alecslupu alecslupu deleted the test/flaky-npm-install branch January 14, 2025 09:15
entantoencuanto added a commit that referenced this pull request Jan 14, 2025
* develop: (27 commits)
  WCAG navigation submenu (#13796)
  Update gem dependencies (part 3) (#13849)
  Prevent notifications for deleted users (#13812)
  Retries NPM installation a couple times to prevent network timeouts (#13831)
  Update gem dependencies (part 2) (#13839)
  Enhance signature pdf export (#13778)
  Fix HexaPDF dependency (#13834)
  Fix flaky spec in authentication (#13827)
  Merge upload field for documents and image on proposal admin form (#13735)
  Update gem dependencies (#13835)
  Upgrade erb_lint to 0.8.0 (#13833)
  Fix flaky spec in geocoder (#13820)
  Refactor modules mounting routes (#13294)
  Upgrade check-spelling action (#13825)
  Add missing images in the custom registration emails from meetings (#13632)
  Add missing translations (#13793)
  Fix proposal map performance with hundreds of markers (#13798)
  Create multiple surveys within same Survey component (#13420)
  Accountability bulk actions (#13730)
  Improve UI for sorting options on comments (#13670)
  ...
@alecslupu alecslupu added release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 labels Jan 15, 2025
rsdeus pushed a commit to octree-gva/decidim that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configuration flaky spec release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants