Create multiple surveys within same Survey component#13420
Merged
Create multiple surveys within same Survey component#13420
Conversation
|
It seems like you did not give us much information about what you are trying to do here. We would appreciate it if you could provide us with more info about this issue/PR! |
Member
|
@ElviaBth is this ready for another review by us? |
Contributor
Author
yes |
alecslupu
suggested changes
Jan 6, 2025
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
Some small changes to do.
103 / 103
decidim-forms/app/controllers/decidim/forms/admin/concerns/has_questionnaire.rb
Show resolved
Hide resolved
decidim-forms/app/controllers/decidim/forms/admin/concerns/has_questionnaire.rb
Outdated
Show resolved
Hide resolved
decidim-forms/app/controllers/decidim/forms/admin/concerns/has_questionnaire.rb
Outdated
Show resolved
Hide resolved
decidim-forms/app/views/decidim/forms/admin/questionnaires/edit_questions.html.erb
Outdated
Show resolved
Hide resolved
decidim-surveys/app/controllers/decidim/surveys/admin/surveys_controller.rb
Show resolved
Hide resolved
decidim-surveys/app/controllers/decidim/surveys/admin/surveys_controller.rb
Outdated
Show resolved
Hide resolved
decidim-surveys/app/controllers/decidim/surveys/admin/surveys_controller.rb
Outdated
Show resolved
Hide resolved
decidim-surveys/app/controllers/decidim/surveys/admin/surveys_controller.rb
Outdated
Show resolved
Hide resolved
decidim-surveys/app/views/decidim/surveys/surveys/index.html.erb
Outdated
Show resolved
Hide resolved
decidim-surveys/db/migrate/20240925124312_add_settings_to_decidim_surveys_surveys.rb
Outdated
Show resolved
Hide resolved
alecslupu
suggested changes
Jan 7, 2025
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
On more try, and we should be ok.
decidim-forms/app/views/decidim/forms/admin/questionnaires/edit_questions.html.erb
Show resolved
Hide resolved
decidim-surveys/db/migrate/20240925124312_add_settings_to_decidim_surveys_surveys.rb
Show resolved
Hide resolved
decidim-surveys/db/migrate/20240925124312_add_settings_to_decidim_surveys_surveys.rb
Outdated
Show resolved
Hide resolved
Dismissing Ivan's review as the changes have already been implemented
mllocs
pushed a commit
that referenced
this pull request
Jan 9, 2025
Co-authored-by: Ivan Vergés <ivan@pokecode.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Allow admins to create more than one resource within the same component and allow me to display the published surveys based on whether they are open or closed.
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
index view
manage questions
edit
public view