Merge upload field for documents and image on proposal admin form#13735
Conversation
decidim-core/lib/decidim/core/test/shared_examples/admin_resource_gallery_examples.rb
Outdated
Show resolved
Hide resolved
decidim-core/lib/decidim/core/test/shared_examples/admin_resource_gallery_examples.rb
Outdated
Show resolved
Hide resolved
decidim-proposals/spec/commands/decidim/proposals/admin/update_proposal_spec.rb
Outdated
Show resolved
Hide resolved
decidim-proposals/spec/commands/decidim/proposals/admin/create_proposal_spec.rb
Outdated
Show resolved
Hide resolved
andreslucena
left a comment
There was a problem hiding this comment.
I have some suggestions in the UX:
This is how it currently looks in this PR:
What I'd expect is this:
The same in the modal title:
This change should be also applied to the other places where this same button/upload is done (i.e. initiatives, debates, etc)
Also in the original issue I proposed to change the image help text: If it's an image, it preferably be a landscape image that does not have any text. The service crops the image.
Can you apply these changes too here?
TBH i would add a new PR to apply the changes in all the places. I would keep this PR exclusively for "merging admin fields" |
…b.com:tremend-cofe/decidim into feature/single-attachement-field-on-proposals
aefbcbb
I'm OK with that approach. As far as I see the documents/attachments mess up is already happening, so at least is consistent xD Can you check the failing specs? |
…gle-attachement-field-on-proposals
@andreslucena , Done! |
* develop: (27 commits) WCAG navigation submenu (#13796) Update gem dependencies (part 3) (#13849) Prevent notifications for deleted users (#13812) Retries NPM installation a couple times to prevent network timeouts (#13831) Update gem dependencies (part 2) (#13839) Enhance signature pdf export (#13778) Fix HexaPDF dependency (#13834) Fix flaky spec in authentication (#13827) Merge upload field for documents and image on proposal admin form (#13735) Update gem dependencies (#13835) Upgrade erb_lint to 0.8.0 (#13833) Fix flaky spec in geocoder (#13820) Refactor modules mounting routes (#13294) Upgrade check-spelling action (#13825) Add missing images in the custom registration emails from meetings (#13632) Add missing translations (#13793) Fix proposal map performance with hundreds of markers (#13798) Create multiple surveys within same Survey component (#13420) Accountability bulk actions (#13730) Improve UI for sorting options on comments (#13670) ...
…cidim#13735) * Merged upload field on proposal admin form * Fixed tests * Run linter * Fixed tests * Removed unused translations * Apply suggestions from code review * Change text * Fix pipelines --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
…3735) * Merged upload field on proposal admin form * Fixed tests * Run linter * Fixed tests * Removed unused translations * Apply suggestions from code review * Change text * Fix pipelines --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
🎩 What? Why?
I have added an attachments field on the admin proposal creation form to merge the document and image fields.
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
The field now looks like: