Adjust form upload label changes#13836
Merged
andreslucena merged 20 commits intodecidim:developfrom Jan 16, 2025
Merged
Conversation
…b.com:tremend-cofe/decidim into feature/single-attachement-field-on-proposals
…gle-attachement-field-on-proposals
…b.com:tremend-cofe/decidim into change/upload-form
andreslucena
requested changes
Jan 15, 2025
Member
andreslucena
left a comment
There was a problem hiding this comment.
Missing one thing from my comment:
- Change "(Optional) Add an attachment" to "Add a document or an image"
andreslucena
approved these changes
Jan 15, 2025
Contributor
Author
|
@andreslucena Can we merge this ? |
Member
Yeah, of course, I missed it |
greenwoodt
pushed a commit
to greenwoodt/decidim
that referenced
this pull request
Jan 21, 2025
* Merged upload field on proposal admin form * Fixed tests * Run linter * Fixed tests * Removed unused translations * Apply suggestions from code review * Change text * Form upload change labels * Fix pipelines * Fix failing specs * Apply review recommendations --------- Co-authored-by: andra-panaite <andra.panaite@tremend.com>
entantoencuanto
added a commit
that referenced
this pull request
Jan 24, 2025
* develop: (30 commits) Change hardcoded english in seeds (#13917) Allow importing accountability results from a Proposals component (#13817) Remove user interests (#13910) Move remaining categories from some resources to taxonomies (#13838) Fix translation issue on import projects mailer (#13894) Update DownloadYourData exports for decidim-debates (#13895) Allow admins to publish the questions' answers in surveys (#13786) Fix flaky spec in autocomplete (#13901) Refine taxonomy filters (part 2) (#13725) Fix single attachment with title (#13795) Fix incorrect breadcrumb encoding on mobile and tablet (#13891) Add string for unpublish survey admin log message (#13890) Fix ux meeting date location (#13872) New Crowdin updates (#13767) Fix deleted user error in schema (#13681) Remove assembly types from user interaction (#13881) Remove participatory process types from user interaction (#13880) Lock concurrent-ruby to 1.3.4 (#13879) Fix taxonomy serialization for export/imports (#13857) Adjust form upload label changes (#13836) ...
antopalidi
pushed a commit
to openpoke/decidim
that referenced
this pull request
Feb 12, 2025
* Merged upload field on proposal admin form * Fixed tests * Run linter * Fixed tests * Removed unused translations * Apply suggestions from code review * Change text * Form upload change labels * Fix pipelines * Fix failing specs * Apply review recommendations --------- Co-authored-by: andra-panaite <andra.panaite@tremend.com>
andreslucena
pushed a commit
that referenced
this pull request
Mar 3, 2025
* Merged upload field on proposal admin form * Fixed tests * Run linter * Fixed tests * Removed unused translations * Apply suggestions from code review * Change text * Form upload change labels * Fix pipelines * Fix failing specs * Apply review recommendations --------- Co-authored-by: andra-panaite <andra.panaite@tremend.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Back in #13735 @andreslucena requested some changes in the UX via #13735 (review) . This PR aims to add those changes
📌 Related Issues
Link your PR to an issue
Testing