Lock concurrent-ruby to 1.3.4 by alecslupu · Pull Request #13879 · decidim/decidim

alecslupu · 2025-01-16T13:49:06Z

🎩 What? Why?

Recently we noticed the pipelines started to fail with the following error:

We are locking to concurrent-ruby 1.3.4 in order to have it backported.

Testing

Pipeline should be green

♥️ Thank you!

andreslucena

Doing a bundle update in the development_app and then a bin/devI could see the same error as I found in Nightly:

$ bin/dev
The Gemfile's dependencies are satisfied
/home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/activesupport-7.0.8.7/lib/active_support/logger_thread_safe_level.rb:12:in `<module:LoggerThreadSafeLevel>': uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)

    Logger::Severity.constants.each do |severity|
    ^^^^^^
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/activesupport-7.0.8.7/lib/active_support/logger_thread_safe_level.rb:9:in `<module:ActiveSupport>'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/activesupport-7.0.8.7/lib/active_support/logger_thread_safe_level.rb:8:in `<main>'
        from /nix/store/mnmpkipbjgjn4sxq5lnw2qqw30d0w3z6-ruby-3.3.4/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
        from /nix/store/mnmpkipbjgjn4sxq5lnw2qqw30d0w3z6-ruby-3.3.4/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/bootsnap-1.18.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/activesupport-7.0.8.7/lib/active_support/logger_silence.rb:5:in `<main>'
        from /nix/store/mnmpkipbjgjn4sxq5lnw2qqw30d0w3z6-ruby-3.3.4/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
        from /nix/store/mnmpkipbjgjn4sxq5lnw2qqw30d0w3z6-ruby-3.3.4/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/bootsnap-1.18.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/activesupport-7.0.8.7/lib/active_support/logger.rb:3:in `<main>'
        from /nix/store/mnmpkipbjgjn4sxq5lnw2qqw30d0w3z6-ruby-3.3.4/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
        from /nix/store/mnmpkipbjgjn4sxq5lnw2qqw30d0w3z6-ruby-3.3.4/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/bootsnap-1.18.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/activesupport-7.0.8.7/lib/active_support.rb:29:in `<main>'
        from /nix/store/mnmpkipbjgjn4sxq5lnw2qqw30d0w3z6-ruby-3.3.4/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
        from /nix/store/mnmpkipbjgjn4sxq5lnw2qqw30d0w3z6-ruby-3.3.4/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/bootsnap-1.18.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/railties-7.0.8.7/lib/rails/command.rb:3:in `<main>'
        from /nix/store/mnmpkipbjgjn4sxq5lnw2qqw30d0w3z6-ruby-3.3.4/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
        from /nix/store/mnmpkipbjgjn4sxq5lnw2qqw30d0w3z6-ruby-3.3.4/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/bootsnap-1.18.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/railties-7.0.8.7/lib/rails/commands.rb:3:in `<main>'
        from /nix/store/mnmpkipbjgjn4sxq5lnw2qqw30d0w3z6-ruby-3.3.4/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
        from /nix/store/mnmpkipbjgjn4sxq5lnw2qqw30d0w3z6-ruby-3.3.4/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/bootsnap-1.18.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
        from /home/apereira/Work/decidim/decidim/development_app/bin/rails:5:in `<top (required)>'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/spring-4.2.1/lib/spring/client/rails.rb:28:in `load'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/spring-4.2.1/lib/spring/client/rails.rb:28:in `call'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/spring-4.2.1/lib/spring/client/command.rb:7:in `call'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/spring-4.2.1/lib/spring/client.rb:30:in `run'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/spring-4.2.1/bin/spring:49:in `<top (required)>'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/spring-4.2.1/lib/spring/binstub.rb:11:in `load'
        from /home/apereira/Work/decidim/decidim/.devenv/state/.bundle/ruby/3.3.0/gems/spring-4.2.1/lib/spring/binstub.rb:11:in `<top (required)>'
        from <internal:/nix/store/mnmpkipbjgjn4sxq5lnw2qqw30d0w3z6-ruby-3.3.4/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
        from <internal:/nix/store/mnmpkipbjgjn4sxq5lnw2qqw30d0w3z6-ruby-3.3.4/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
        from /home/apereira/Work/decidim/decidim/development_app/bin/spring:12:in `block in <top (required)>'
        from <internal:kernel>:90:in `tap'
        from /home/apereira/Work/decidim/decidim/development_app/bin/spring:9:in `<top (required)>'
        from bin/rails:2:in `load'
        from bin/rails:2:in `<main>'

Using this branch and doing the bundle update again fixes the problem.

LGTM

* develop: (30 commits) Change hardcoded english in seeds (#13917) Allow importing accountability results from a Proposals component (#13817) Remove user interests (#13910) Move remaining categories from some resources to taxonomies (#13838) Fix translation issue on import projects mailer (#13894) Update DownloadYourData exports for decidim-debates (#13895) Allow admins to publish the questions' answers in surveys (#13786) Fix flaky spec in autocomplete (#13901) Refine taxonomy filters (part 2) (#13725) Fix single attachment with title (#13795) Fix incorrect breadcrumb encoding on mobile and tablet (#13891) Add string for unpublish survey admin log message (#13890) Fix ux meeting date location (#13872) New Crowdin updates (#13767) Fix deleted user error in schema (#13681) Remove assembly types from user interaction (#13881) Remove participatory process types from user interaction (#13880) Lock concurrent-ruby to 1.3.4 (#13879) Fix taxonomy serialization for export/imports (#13857) Adjust form upload label changes (#13836) ...

Lock concurrent-ruby to 1.3.4

10195f7

alecslupu added type: fix PRs that implement a fix for a bug release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 labels Jan 16, 2025

github-actions bot approved these changes Jan 16, 2025

View reviewed changes

github-actions bot added module: core dependencies Pull requests that update a dependency file or issues that talk about updating dependencies module: generators type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Jan 16, 2025

alecslupu requested a review from andreslucena January 16, 2025 14:25

alecslupu assigned andreslucena Jan 16, 2025

andreslucena approved these changes Jan 20, 2025

View reviewed changes

andreslucena merged commit f4145fa into develop Jan 20, 2025

andreslucena deleted the chore/deps/concurrent-ruby branch January 20, 2025 10:30

This was referenced Jan 20, 2025

Backport 'Lock concurrent-ruby to 1.3.4' to v0.28 #13884

Merged

Backport 'Lock concurrent-ruby to 1.3.4' to v0.29 #13885

Merged

greenwoodt pushed a commit to greenwoodt/decidim that referenced this pull request Jan 21, 2025

Lock concurrent-ruby to 1.3.4 (decidim#13879)

1d3b3b8

andreslucena mentioned this pull request Jan 21, 2025

Can't upgrade Decidim because of latest version of concurrent-ruby #13886

Closed

antopalidi pushed a commit to openpoke/decidim that referenced this pull request Feb 12, 2025

Lock concurrent-ruby to 1.3.4 (decidim#13879)

351593d

andreslucena pushed a commit that referenced this pull request Mar 3, 2025

Lock concurrent-ruby to 1.3.4 (#13879)

d953195

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Lock concurrent-ruby to 1.3.4#13879

Lock concurrent-ruby to 1.3.4#13879
andreslucena merged 1 commit intodevelopfrom
chore/deps/concurrent-ruby

alecslupu commented Jan 16, 2025

Uh oh!

andreslucena left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

alecslupu commented Jan 16, 2025

🎩 What? Why?

Testing

Uh oh!

andreslucena left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants