Fix deleted user error in schema by alecslupu · Pull Request #13681 · decidim/decidim

alecslupu · 2024-11-19T16:03:53Z

🎩 What? Why?

While reviewing #13666, i have accidentally entered in a meeting where the author has deleted its account, and as a result i got the classic error when the author is missing.

Additionally, I have tried to remove the duplication formed around the profile_url method.

Stacktrace

17:59:01 web.1         | ActionView::Template::Error (No route matches {:action=>"show", :controller=>"decidim/profiles", :nickname=>""}, possible unmatched constraints: [:nickname]):
17:59:01 web.1         |     1: <script type="application/ld+json">
17:59:01 web.1         |     2: <%== render_schema_org_event_meeting(meeting) %>
17:59:01 web.1         |     3: </script>
17:59:01 web.1         |   
17:59:01 web.1         | actionpack (7.0.8.4) lib/action_dispatch/journey/formatter.rb:44:in `path'
17:59:01 web.1         | actionpack (7.0.8.4) lib/action_dispatch/routing/route_set.rb:824:in `url_for'
17:59:01 web.1         | actionpack (7.0.8.4) lib/action_dispatch/routing/route_set.rb:271:in `call'
17:59:01 web.1         | actionpack (7.0.8.4) lib/action_dispatch/routing/route_set.rb:327:in `block in define_url_helper'
17:59:01 web.1         | actionpack (7.0.8.4) lib/action_dispatch/routing/routes_proxy.rb:45:in `profile_url'
17:59:01 web.1         | /home/alecslupu/Sites/decidim/redesign/decidim-core/lib/decidim/engine_router.rb:50:in `method_missing'
17:59:01 web.1         | /home/alecslupu/Sites/decidim/redesign/decidim-meetings/lib/decidim/meetings/schema_org_event_meeting_serializer.rb:72:in `organizer_user'
17:59:01 web.1         | /home/alecslupu/Sites/decidim/redesign/decidim-meetings/lib/decidim/meetings/schema_org_event_meeting_serializer.rb:48:in `organizer'
17:59:01 web.1         | /home/alecslupu/Sites/decidim/redesign/decidim-meetings/lib/decidim/meetings/schema_org_event_meeting_serializer.rb:27:in `serialize'
17:59:01 web.1         | /home/alecslupu/Sites/decidim/redesign/decidim-core/app/serializers/decidim/exporters/serializer.rb:24:in `run'
17:59:01 web.1         | /home/alecslupu/Sites/decidim/redesign/decidim-core/lib/decidim/exporters/json.rb:16:in `block in export'
17:59:01 web.1         | /home/alecslupu/Sites/decidim/redesign/decidim-core/lib/decidim/exporters/json.rb:15:in `map'
17:59:01 web.1         | /home/alecslupu/Sites/decidim/redesign/decidim-core/lib/decidim/exporters/json.rb:15:in `export'
17:59:01 web.1         | /home/alecslupu/Sites/decidim/redesign/decidim-meetings/app/helpers/decidim/meetings/meetings_helper.rb:147:in `render_schema_org_event_meeting'
17:59:01 web.1         | /home/alecslupu/Sites/decidim/redesign/decidim-meetings/app/views/decidim/meetings/meetings/_schema_org_event_meeting.html.erb:2
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/base.rb:244:in `public_send'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/base.rb:244:in `_run'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/template.rb:157:in `block in render'
17:59:02 web.1         | activesupport (7.0.8.4) lib/active_support/notifications.rb:208:in `instrument'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/template.rb:361:in `instrument_render_template'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/template.rb:155:in `render'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/renderer/partial_renderer.rb:251:in `block in render_partial_template'
17:59:02 web.1         | activesupport (7.0.8.4) lib/active_support/notifications.rb:206:in `block in instrument'
17:59:02 web.1         | activesupport (7.0.8.4) lib/active_support/notifications/instrumenter.rb:24:in `instrument'
17:59:02 web.1         | activesupport (7.0.8.4) lib/active_support/notifications.rb:206:in `instrument'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/renderer/partial_renderer.rb:246:in `render_partial_template'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/renderer/partial_renderer.rb:237:in `render'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/renderer/renderer.rb:81:in `render_partial_to_object'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/renderer/renderer.rb:27:in `render_to_object'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/renderer/renderer.rb:22:in `render'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/helpers/rendering_helper.rb:37:in `block in render'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/base.rb:270:in `in_rendering_context'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/helpers/rendering_helper.rb:33:in `render'
17:59:02 web.1         | /home/alecslupu/Sites/decidim/redesign/decidim-meetings/app/views/decidim/meetings/meetings/_meeting.html.erb:3
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/helpers/capture_helper.rb:45:in `block in capture'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/helpers/capture_helper.rb:209:in `with_output_buffer'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/helpers/capture_helper.rb:45:in `capture'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/helpers/rendering_helper.rb:101:in `_layout_for'
17:59:02 web.1         | actionview (7.0.8.4) lib/action_view/renderer/partial_renderer.rb:252:in `block (2 levels) in render_partial_template'
17:59:02 web.1         | /home/alecslupu/Sites/decidim/redesign/decidim-core/app/views/layouts/decidim/shared/_layout_item.html.erb:10

📌 Related Issues

Link your PR to an issue

Related to Add schema.org Event serializer for Meetings #13406
Related to Add schema.org Event serializer for BlogPosts #13439

Testing

Using a newly created user, create a meeting
Visit the meeting page
Delete the user account
Visit the meeting page
See the error
Apply patch
See error is gone.

📷 Screenshots

Please add screenshots of the changes you are proposing

♥️ Thank you!

greenwoodt

👍🏽

greenwoodt · 2024-11-26T10:19:13Z

Looks all good! Requesting a second set of eyes from @andreslucena!

andreslucena · 2024-12-11T10:00:42Z

@alecslupu as we have other PRs changing serializers and I don't want to introduce merge conflicts with them, we'll check this one out once #13740 #13702 and #13675 are merged

…_users_in_schema

andreslucena

As this was detected with a 500 error, can you add a system spec with the example of a deleted user author for meetings and proposals? Thanks

…_users_in_schema

decidim-pages/lib/decidim/pages/page_serializer.rb

decidim-accountability/lib/decidim/accountability/result_serializer.rb

decidim-budgets/lib/decidim/budgets/project_serializer.rb

alecslupu · 2025-01-21T11:30:33Z

As this was detected with a 500 error, can you add a system spec with the example of a deleted user author for meetings and proposals? Thanks

@andreslucena , this should be ready for a new review.

andreslucena · 2025-01-21T13:46:00Z

@alecslupu seems like the failing spec is relevant, can you check it out 🙏🏽 ? Thanks

andreslucena · 2025-01-22T09:51:49Z

Merging with the only failing check of codecov

* develop: (30 commits) Change hardcoded english in seeds (#13917) Allow importing accountability results from a Proposals component (#13817) Remove user interests (#13910) Move remaining categories from some resources to taxonomies (#13838) Fix translation issue on import projects mailer (#13894) Update DownloadYourData exports for decidim-debates (#13895) Allow admins to publish the questions' answers in surveys (#13786) Fix flaky spec in autocomplete (#13901) Refine taxonomy filters (part 2) (#13725) Fix single attachment with title (#13795) Fix incorrect breadcrumb encoding on mobile and tablet (#13891) Add string for unpublish survey admin log message (#13890) Fix ux meeting date location (#13872) New Crowdin updates (#13767) Fix deleted user error in schema (#13681) Remove assembly types from user interaction (#13881) Remove participatory process types from user interaction (#13880) Lock concurrent-ruby to 1.3.4 (#13879) Fix taxonomy serialization for export/imports (#13857) Adjust form upload label changes (#13836) ...

* Fix deleted user error in schema * Fix failing specs * Remove method override * Refactor * Fix specs * Refactor page serializer * Fix specs on meetings and proposals * Add specs for blogs and debates * Fix debates spec * Fix spec

Fix deleted user error in schema

cc9cd37

alecslupu added type: fix PRs that implement a fix for a bug no-backport Pull Requests that should not be backported labels Nov 19, 2024

github-actions bot previously approved these changes Nov 19, 2024

View reviewed changes

Fix failing specs

0d6dfdc

alecslupu dismissed github-actions[bot]’s stale review via 0d6dfdc November 19, 2024 16:30

github-actions bot previously approved these changes Nov 19, 2024

View reviewed changes

alecslupu assigned greenwoodt Nov 21, 2024

alecslupu requested a review from greenwoodt November 21, 2024 09:25

greenwoodt previously approved these changes Nov 26, 2024

View reviewed changes

greenwoodt requested a review from andreslucena November 26, 2024 10:18

alecslupu assigned andreslucena Dec 2, 2024

andreslucena assigned fblupi and unassigned andreslucena Dec 4, 2024

Merge branch 'develop' into fix/deleted_users_in_schema

ce1a73a

github-actions bot added module: proposals module: core module: meetings module: debates module: blogs labels Dec 9, 2024

alecslupu mentioned this pull request Dec 9, 2024

Add new PR labeler #13726

Merged

Merge branch 'develop' into fix/deleted_users_in_schema

37831c8

alecslupu assigned andreslucena Dec 10, 2024

alecslupu added 2 commits December 19, 2024 12:40

Merge branch 'develop' of github.com:decidim/decidim into fix/deleted…

90c9faf

…_users_in_schema

Remove method override

2cad120

alecslupu dismissed stale reviews from github-actions[bot] and greenwoodt via 2cad120 December 19, 2024 10:46

github-actions bot previously approved these changes Dec 19, 2024

View reviewed changes

github-actions bot previously approved these changes Jan 16, 2025

View reviewed changes

andreslucena added this to the 0.30.0 milestone Jan 20, 2025

andreslucena requested changes Jan 20, 2025

View reviewed changes

alecslupu added 2 commits January 21, 2025 12:16

Merge branch 'develop' of github.com:decidim/decidim into fix/deleted…

f6895d0

…_users_in_schema

Fix specs on meetings and proposals

3ca814e

alecslupu dismissed github-actions[bot]’s stale review via 3ca814e January 21, 2025 11:08

github-actions bot previously approved these changes Jan 21, 2025

View reviewed changes

Add specs for blogs and debates

8606920

alecslupu dismissed github-actions[bot]’s stale review via 8606920 January 21, 2025 11:28

alecslupu commented Jan 21, 2025

View reviewed changes

decidim-pages/lib/decidim/pages/page_serializer.rb Show resolved Hide resolved

decidim-accountability/lib/decidim/accountability/result_serializer.rb Show resolved Hide resolved

decidim-budgets/lib/decidim/budgets/project_serializer.rb Show resolved Hide resolved

alecslupu requested a review from andreslucena January 21, 2025 11:30

github-actions bot previously approved these changes Jan 21, 2025

View reviewed changes

andreslucena previously approved these changes Jan 21, 2025

View reviewed changes

Fix debates spec

004eb63

alecslupu dismissed stale reviews from andreslucena and github-actions[bot] via 004eb63 January 21, 2025 12:17

github-actions bot previously approved these changes Jan 21, 2025

View reviewed changes

Fix spec

c7b50b4

alecslupu dismissed github-actions[bot]’s stale review via c7b50b4 January 21, 2025 13:49

github-actions bot approved these changes Jan 21, 2025

View reviewed changes

alecslupu requested a review from andreslucena January 21, 2025 15:30

andreslucena approved these changes Jan 22, 2025

View reviewed changes

andreslucena merged commit c0a9d5c into develop Jan 22, 2025

andreslucena deleted the fix/deleted_users_in_schema branch January 22, 2025 09:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix deleted user error in schema#13681

Fix deleted user error in schema#13681
andreslucena merged 20 commits intodevelopfrom
fix/deleted_users_in_schema

alecslupu commented Nov 19, 2024

Uh oh!

greenwoodt left a comment

Uh oh!

greenwoodt commented Nov 26, 2024

Uh oh!

andreslucena commented Dec 11, 2024

Uh oh!

andreslucena left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alecslupu commented Jan 21, 2025

Uh oh!

andreslucena commented Jan 21, 2025

Uh oh!

andreslucena commented Jan 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

alecslupu commented Nov 19, 2024

🎩 What? Why?

📌 Related Issues

Testing

📷 Screenshots

Uh oh!

greenwoodt left a comment

Choose a reason for hiding this comment

Uh oh!

greenwoodt commented Nov 26, 2024

Uh oh!

andreslucena commented Dec 11, 2024

Uh oh!

andreslucena left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alecslupu commented Jan 21, 2025

Uh oh!

andreslucena commented Jan 21, 2025

Uh oh!

andreslucena commented Jan 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants