Hide the public export for Projects votes#13740
Merged
andreslucena merged 2 commits intodecidim:developfrom Dec 13, 2024
Merged
Hide the public export for Projects votes#13740andreslucena merged 2 commits intodecidim:developfrom
andreslucena merged 2 commits intodecidim:developfrom
Conversation
andreslucena
approved these changes
Dec 11, 2024
andreslucena
approved these changes
Dec 13, 2024
Member
|
Merging with the only failing check of codecov |
antopalidi
pushed a commit
that referenced
this pull request
Dec 16, 2024
* extracted fix from #12348 for condition of votes count when voting is disabled * removed inundated test for displaying votes always in export
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Inspired fix from here and #13739, the Projects component now hides
show_votes, when the user disabled the option, allowing exportable data not to display the information.Should be merged directly after: #13675
📌 Related Issues
Testing
decidim-budgets/spec/serializers/project_serializer_spec.rb📷 Screenshots