Hide the public export for proposals' votes#13739
Merged
andreslucena merged 1 commit intodecidim:developfrom Dec 11, 2024
Merged
Hide the public export for proposals' votes#13739andreslucena merged 1 commit intodecidim:developfrom
andreslucena merged 1 commit intodecidim:developfrom
Conversation
votes_count hidden
andreslucena
approved these changes
Dec 11, 2024
This was referenced Dec 11, 2024
antopalidi
pushed a commit
that referenced
this pull request
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
A fix which is also applicable to Projects within Budgets, which allows CSV exports of the module not to contain
proposal_vote_countupon export due to disabling theshow_votesoption.Should be merged after #13702.
📌 Related Issues
Testing
Run
decidim-proposals/spec/services/decidim/proposals/proposal_serializer_spec.rb📷 Screenshots