Skip to content

Add string for unpublish survey admin log message#13890

Merged
alecslupu merged 2 commits intodevelopfrom
fix/admin-log-unpublish-survey
Jan 22, 2025
Merged

Add string for unpublish survey admin log message#13890
alecslupu merged 2 commits intodevelopfrom
fix/admin-log-unpublish-survey

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

While working on #13786, I noticed that when an admin unpublishes a Survey we have the "performed some action" message, as we don't have this action defined. This PR fixes it.

Testing

  1. Sign in as admin
  2. Go to a survey
  3. Unpublish it
  4. Go to the admin dashboard homepage and check out the "Admin log" section
  5. (Before this PR) see that you have the "performed some action" message
  6. (After this PR) see that you have the message "unpublished a survey"

📷 Screenshots

Before

Screenshot of the bug

After

Screenshot of the fix

♥️ Thank you!

@andreslucena andreslucena added the type: fix PRs that implement a fix for a bug label Jan 21, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 21, 2025
@andreslucena
Copy link
Copy Markdown
Member Author

@alecslupu this is ready for your magic 🪄

@alecslupu alecslupu added the no-backport Pull Requests that should not be backported label Jan 22, 2025
@alecslupu
Copy link
Copy Markdown
Contributor

Adding no-backport as the missing string comes from #13420

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit c7bc8bf into develop Jan 22, 2025
@alecslupu alecslupu deleted the fix/admin-log-unpublish-survey branch January 22, 2025 13:32
entantoencuanto added a commit that referenced this pull request Jan 24, 2025
* develop: (30 commits)
  Change hardcoded english in seeds (#13917)
  Allow importing accountability results from a Proposals component (#13817)
  Remove user interests (#13910)
  Move remaining categories from some resources to taxonomies (#13838)
  Fix translation issue on import projects mailer (#13894)
  Update DownloadYourData exports for decidim-debates (#13895)
  Allow admins to publish the questions' answers in surveys (#13786)
  Fix flaky spec in autocomplete (#13901)
  Refine taxonomy filters (part 2) (#13725)
  Fix single attachment with title (#13795)
  Fix incorrect breadcrumb encoding on mobile and tablet (#13891)
  Add string for unpublish survey admin log message (#13890)
  Fix ux meeting date location (#13872)
  New Crowdin updates (#13767)
  Fix deleted user error in schema (#13681)
  Remove assembly types from user interaction (#13881)
  Remove participatory process types from user interaction (#13880)
  Lock concurrent-ruby to 1.3.4 (#13879)
  Fix taxonomy serialization for export/imports (#13857)
  Adjust form upload label changes (#13836)
  ...
antopalidi pushed a commit to openpoke/decidim that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: surveys no-backport Pull Requests that should not be backported type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants