Skip to content

Remove participatory process types from user interaction#13880

Merged
alecslupu merged 9 commits intodevelopfrom
chore/remove-space-types-controllers
Jan 20, 2025
Merged

Remove participatory process types from user interaction#13880
alecslupu merged 9 commits intodevelopfrom
chore/remove-space-types-controllers

Conversation

@microstudi
Copy link
Copy Markdown
Contributor

@microstudi microstudi commented Jan 17, 2025

🎩 What? Why?

Removes Participatory process types from admin and end user interaction. Mainly, controllers, views and filters are no longer available.

  • Removes admin controllers
  • Remove filtering by type in the frontend
  • Remove process types in imports

Other internal features related to participatory process types are still present (they should be removed in the next version of Decidim):

  • Remove types from exports
  • Remove models and associations
  • Remove presenters, deal with history in admin log when a process type is refereed.
  • Remove types from graphql

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@github-actions github-actions bot added module: participatory processes type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Jan 17, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 17, 2025
@request-info
Copy link
Copy Markdown

request-info bot commented Jan 17, 2025

It seems like you did not give us much information about what you are trying to do here. We would appreciate it if you could provide us with more info about this issue/PR!

github-actions[bot]
github-actions bot previously approved these changes Jan 17, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 17, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 17, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 17, 2025
@microstudi microstudi marked this pull request as ready for review January 20, 2025 08:45
github-actions[bot]
github-actions bot previously approved these changes Jan 20, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 20, 2025
@microstudi microstudi requested a review from alecslupu January 20, 2025 12:35
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, but there is something extra that needs to be removed. You have not removed the participatory_process_type factory . Let's do that as well, and see what else is failing.

@alecslupu alecslupu self-assigned this Jan 20, 2025
@alecslupu
Copy link
Copy Markdown
Contributor

The PR looks good, but there is something extra that needs to be removed. You have not removed the participatory_process_type factory . Let's do that as well, and see what else is failing.

Apart of that, the model has been left behind. Could you remove that as well ?

@alecslupu
Copy link
Copy Markdown
Contributor

After a discussion with @microstudi , i have documented the requested changes in #13887. We will proceed with merging.

@alecslupu alecslupu merged commit 412bd40 into develop Jan 20, 2025
@alecslupu alecslupu deleted the chore/remove-space-types-controllers branch January 20, 2025 19:08
greenwoodt pushed a commit to greenwoodt/decidim that referenced this pull request Jan 21, 2025
entantoencuanto added a commit that referenced this pull request Jan 24, 2025
* develop: (30 commits)
  Change hardcoded english in seeds (#13917)
  Allow importing accountability results from a Proposals component (#13817)
  Remove user interests (#13910)
  Move remaining categories from some resources to taxonomies (#13838)
  Fix translation issue on import projects mailer (#13894)
  Update DownloadYourData exports for decidim-debates (#13895)
  Allow admins to publish the questions' answers in surveys (#13786)
  Fix flaky spec in autocomplete (#13901)
  Refine taxonomy filters (part 2) (#13725)
  Fix single attachment with title (#13795)
  Fix incorrect breadcrumb encoding on mobile and tablet (#13891)
  Add string for unpublish survey admin log message (#13890)
  Fix ux meeting date location (#13872)
  New Crowdin updates (#13767)
  Fix deleted user error in schema (#13681)
  Remove assembly types from user interaction (#13881)
  Remove participatory process types from user interaction (#13880)
  Lock concurrent-ruby to 1.3.4 (#13879)
  Fix taxonomy serialization for export/imports (#13857)
  Adjust form upload label changes (#13836)
  ...
antopalidi pushed a commit to openpoke/decidim that referenced this pull request Feb 12, 2025
@andreslucena andreslucena added the type: removal PRs that implement a removal of a functionality or code label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: admin module: participatory processes type: internal PRs that aren't necessary to add to the CHANGELOG for implementers type: removal PRs that implement a removal of a functionality or code

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants