Remove legacy categorization systems#13821
Closed
microstudi wants to merge 71 commits intodevelopfrom
Closed
Conversation
…scope-area-from-forms
6 tasks
…-old-categorizations
alecslupu
reviewed
Jan 25, 2025
| resource :publish, controller: "participatory_process_publications", only: [:create, :destroy] | ||
| resources :copies, controller: "participatory_process_copies", only: [:new, :create] | ||
|
|
||
| collection do |
Contributor
There was a problem hiding this comment.
There is an issue with this file.
It seems that lines 38 to 74 are duplicates.
Contributor
Author
|
@alecslupu sorry, don't review this. We won't merge it, this code will stay for now (It should be remove on the next version). I've merged develop here to see how fare are we to completly clean the system from old stuff (there's still missing things here). After speaking with product I'll close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOT FOR MERGE.
This PR is for getting an idea of the size of the task.
I think the minimal amount of work to achieve this (concerning what an administrator sees and manages) will require:
Remove Areas and Scopes views & controllers from the adminAreas and Scopes are still used in initiatives. Maybe a message should be placed on top of the index views to state that this is deprecated, only used in initiatives and will be removed when initiatives will be using taxonomies.In my opinion, all these task should be completed before releasing the 0.30 version