Skip to content

Refine taxonomy filters (part 2)#13725

Merged
alecslupu merged 36 commits intodevelopfrom
feature/yet-another-taxonomy-refinement
Jan 22, 2025
Merged

Refine taxonomy filters (part 2)#13725
alecslupu merged 36 commits intodevelopfrom
feature/yet-another-taxonomy-refinement

Conversation

@microstudi
Copy link
Copy Markdown
Contributor

@microstudi microstudi commented Dec 4, 2024

🎩 What? Why?

What this PR does is to change the configuration of filters from participatory spaces to a single, centralized place under the "taxonomies" organization settings.

  • Remove old participatory space taxonomy filter controllers
  • New global taxonomy filters controller & views
  • Implement proper breadcrumb in taxonomy/taxonomy filters
  • Refactor the space_filter property (convert to array)
  • Modify the filter assignation to components
  • Rebuild the drawer for assigning filters in components
  • Specs
  • traceability for changing filters

fixes

  • Saving the component does not loose filters
  • components counter
  • date filter meetings
  • filter in conferences initiatives

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@request-info
Copy link
Copy Markdown

request-info bot commented Dec 4, 2024

It seems like you did not give us much information about what you are trying to do here. We would appreciate it if you could provide us with more info about this issue/PR!

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@alecslupu alecslupu added the project: 2024-developments Barcelona City Council contract label Dec 4, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 9, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 9, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 16, 2024
@microstudi microstudi marked this pull request as ready for review December 16, 2024 14:34
@microstudi
Copy link
Copy Markdown
Contributor Author

microstudi commented Dec 16, 2024

@andreslucena this wasn't ready yet, now it is!

@andreslucena andreslucena assigned alecslupu and unassigned carolromero Jan 8, 2025
@microstudi microstudi requested a review from alecslupu January 8, 2025 09:57
@microstudi
Copy link
Copy Markdown
Contributor Author

@alecslupu @andreslucena this is approved by @carolromero. You may proceed with the dissection!

github-actions[bot]
github-actions bot previously approved these changes Jan 14, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 22, 2025
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Overall i like the interface changes that have been done. I only have a small improvement.

144 / 144

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @microstudi !

Merging with green pipeline.

@alecslupu alecslupu merged commit 878c512 into develop Jan 22, 2025
@alecslupu alecslupu deleted the feature/yet-another-taxonomy-refinement branch January 22, 2025 18:37
entantoencuanto added a commit that referenced this pull request Jan 24, 2025
* develop: (30 commits)
  Change hardcoded english in seeds (#13917)
  Allow importing accountability results from a Proposals component (#13817)
  Remove user interests (#13910)
  Move remaining categories from some resources to taxonomies (#13838)
  Fix translation issue on import projects mailer (#13894)
  Update DownloadYourData exports for decidim-debates (#13895)
  Allow admins to publish the questions' answers in surveys (#13786)
  Fix flaky spec in autocomplete (#13901)
  Refine taxonomy filters (part 2) (#13725)
  Fix single attachment with title (#13795)
  Fix incorrect breadcrumb encoding on mobile and tablet (#13891)
  Add string for unpublish survey admin log message (#13890)
  Fix ux meeting date location (#13872)
  New Crowdin updates (#13767)
  Fix deleted user error in schema (#13681)
  Remove assembly types from user interaction (#13881)
  Remove participatory process types from user interaction (#13880)
  Lock concurrent-ruby to 1.3.4 (#13879)
  Fix taxonomy serialization for export/imports (#13857)
  Adjust form upload label changes (#13836)
  ...
antopalidi pushed a commit to openpoke/decidim that referenced this pull request Feb 12, 2025
Co-authored-by: Ivan Vergés <Ivan Vergés>
andreslucena pushed a commit that referenced this pull request Mar 3, 2025
Co-authored-by: Ivan Vergés <Ivan Vergés>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refine taxonomy filters

5 participants