Conversation
|
It seems like you did not give us much information about what you are trying to do here. We would appreciate it if you could provide us with more info about this issue/PR! |
carolromero
left a comment
There was a problem hiding this comment.
@microstudi I just left you a small typo. For the rest, everything working as expected except for the weird behavior detected in Taxonomies item creation, but I guess we can leave this out of this PR. You did an amazing job, kudos!
ee76eae
alecslupu
left a comment
There was a problem hiding this comment.
@microstudi , i think you need to also patch :
- decidim-proposals/app/views/decidim/proposals/admin/proposals/_form.html.erb
Also there are failing specs
decidim-budgets/app/controllers/decidim/budgets/admin/projects_controller.rb
Outdated
Show resolved
Hide resolved
alecslupu
left a comment
There was a problem hiding this comment.
one small style change in the translation file, and this should be ok.
There was a problem hiding this comment.
Based on the latest changes, i can see that we have opted to display the internal: true flag only for participatory processes.
There are no more changes that i would do in the scope of this PR.
LGTM. Thanks @microstudi for your support!
🎩 What? Why?
Several refinement for taxonomies after its initial introduction.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📷 Screenshots
Please add screenshots of the changes you are proposing
