Allow importing accountability results from a Proposals component#13817
Merged
Allow importing accountability results from a Proposals component#13817
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
|
Last comment: #13696 (review) Last reply: #13696 (comment) |
Member
|
@mllocs I changed the title of this and the original PR, as the title of this will be the commit message and we don't want noise there |
Member
|
@mllocs can you solve the git conflicts 🙏🏽 ? |
Contributor
Author
Done |
Contributor
Author
|
ping @andreslucena @alecslupu |
Contributor
|
@mllocs I will review this today. Could you merge with latest develop ? You're 25 commits behind, and there may be issues. |
alecslupu
suggested changes
Jan 22, 2025
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
There are some changes required. Could you have a look ?
decidim-accountability/app/jobs/decidim/accountability/admin/import_proposals_job.rb
Outdated
Show resolved
Hide resolved
decidim-accountability/spec/forms/admin/import_component_form_spec.rb
Outdated
Show resolved
Hide resolved
decidim-accountability/spec/forms/admin/import_component_form_spec.rb
Outdated
Show resolved
Hide resolved
decidim-accountability/app/mailers/decidim/accountability/import_proposals_mailer.rb
Show resolved
Hide resolved
decidim-accountability/app/views/decidim/accountability/import_proposals_mailer/import.html.erb
Outdated
Show resolved
Hide resolved
alecslupu
approved these changes
Jan 23, 2025
entantoencuanto
added a commit
that referenced
this pull request
Jan 24, 2025
* develop: (30 commits) Change hardcoded english in seeds (#13917) Allow importing accountability results from a Proposals component (#13817) Remove user interests (#13910) Move remaining categories from some resources to taxonomies (#13838) Fix translation issue on import projects mailer (#13894) Update DownloadYourData exports for decidim-debates (#13895) Allow admins to publish the questions' answers in surveys (#13786) Fix flaky spec in autocomplete (#13901) Refine taxonomy filters (part 2) (#13725) Fix single attachment with title (#13795) Fix incorrect breadcrumb encoding on mobile and tablet (#13891) Add string for unpublish survey admin log message (#13890) Fix ux meeting date location (#13872) New Crowdin updates (#13767) Fix deleted user error in schema (#13681) Remove assembly types from user interaction (#13881) Remove participatory process types from user interaction (#13880) Lock concurrent-ruby to 1.3.4 (#13879) Fix taxonomy serialization for export/imports (#13857) Adjust form upload label changes (#13836) ...
antopalidi
pushed a commit
to openpoke/decidim
that referenced
this pull request
Feb 12, 2025
andreslucena
pushed a commit
that referenced
this pull request
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
📌 Related Issues
Testing
https://decidim-lot2.populate.tools/admin/participatory_processes/branch-highway/components/1/manage/import_components/new
📷 Screenshots