Skip to content

(Deprecated) Allow importing accountability results from a Proposals component#13696

Closed
mllocs wants to merge 27 commits intodevelopfrom
feat/import-results-from-proposals-with-filters
Closed

(Deprecated) Allow importing accountability results from a Proposals component#13696
mllocs wants to merge 27 commits intodevelopfrom
feat/import-results-from-proposals-with-filters

Conversation

@mllocs
Copy link
Copy Markdown
Contributor

@mllocs mllocs commented Nov 26, 2024

🎩 What? Why?

  • Allow importing results from a Proposals component.
  • Adds taxonomies filters for both Budget and Proposal components.
  • Adds Proposal state filter.
  • The message "X results will be imported" works with the new filters.

📌 Related Issues

Testing

  • Import Budget component
  • Import Proposals component
  • Test Taxonomies filters
  • Test Proposal status filters
  • Test count message (1 proposal will be imported)

https://decidim-lot2.populate.tools/admin/participatory_processes/branch-highway/components/1/manage/import_components/new

📷 Screenshots

Screenshot 2024-11-26 at 10 59 01

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@mllocs mllocs self-assigned this Nov 26, 2024
github-actions[bot]
github-actions Bot previously approved these changes Nov 26, 2024
github-actions[bot]
github-actions Bot previously approved these changes Nov 26, 2024
github-actions[bot]
github-actions Bot previously approved these changes Nov 27, 2024
github-actions[bot]
github-actions Bot previously approved these changes Nov 27, 2024
@mllocs mllocs marked this pull request as ready for review November 27, 2024 13:56
@mllocs mllocs requested a review from furilo November 27, 2024 13:56
@furilo
Copy link
Copy Markdown
Contributor

furilo commented Nov 27, 2024

@NilHomedes some issues (that arise from the fact that we are finding really difficult to understand how the system works/should work)

  1. when a proposal is imported into a result, it is left without a category, and results without categories are not shown in the front.
  2. when a proposal is imported into a result, the Proposals field in the Result should have the reference of the proposal that has been imported?

Maybe you can go on testing, because it's being really difficult for me to understand how this should work.

@furilo
Copy link
Copy Markdown
Contributor

furilo commented Nov 28, 2024

@NilHomedes

  • we should implement that when a proposal is imported we assign in the imported result the proposal it was imported from, right?

64270

  • for the time being we don't do anything regarding the lack of category by default, since this will be solved with the mass assignment issue we have next

Anything else?

cc @mllocs

@alecslupu alecslupu added the project: 2024-developments Barcelona City Council contract label Nov 29, 2024
@mllocs mllocs requested a review from NilHomedes November 29, 2024 11:46
@NilHomedes
Copy link
Copy Markdown
Member

we should implement that when a proposal is imported we assign in the imported result the proposal it was imported from, right?

Yes that's it.

for the time being we don't do anything regarding the lack of category by default, since this will be solved with the mass assignment issue we have next.

Correct. Maybe in the future we can include the option to automatically import the category.

github-actions[bot]
github-actions Bot previously approved these changes Dec 2, 2024
github-actions[bot]
github-actions Bot previously approved these changes Dec 5, 2024
alecslupu and others added 6 commits January 9, 2025 11:45
#13805)

* fix: redirect user to the intented page

* fix: removing duplicate lines in the code

* fix: npm lint errors

* fix: minor code improvements for clarity

* Add Specs

---------

Co-authored-by: Renato <renato@octree.ch>
* Added "Sort by" into the select dropdown

* Resolved comment

* Run linter

* Removed bold style  from select

* Resolved comment

* Added changes only to mobile view

* Running linters

* Removed duplicated id

* Fixed accessibility issues

* Apply suggestions from code review

* Apply review recommendation

* Running linters

* Fix accessibility

---------

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Ivan Vergés <ivan@pokecode.net>
@mllocs
Copy link
Copy Markdown
Contributor Author

mllocs commented Jan 9, 2025

@alecslupu sorry I had an issue with the branch, I'm closing this PR in favor of #13817

@mllocs mllocs closed this Jan 9, 2025
@andreslucena andreslucena changed the title Allow importing accountability results from a Proposals component (Deprecated) Allow importing accountability results from a Proposals component Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow importing proposals to results