Skip to content

Update DownloadYourData exports for decidim-debates#13895

Merged
alecslupu merged 7 commits intodevelopfrom
feature/download-your-data/debates
Jan 23, 2025
Merged

Update DownloadYourData exports for decidim-debates#13895
alecslupu merged 7 commits intodevelopfrom
feature/download-your-data/debates

Conversation

@andreslucena
Copy link
Copy Markdown
Member

@andreslucena andreslucena commented Jan 22, 2025

🎩 What? Why?

This PR updates the DownloadYourData exports for decidim-debates models.

On this case what I'm doing is:

  • Simplifying DebateSerializer (you can see the reasoning in each commit, I tried to made them granular)
  • Instead of re-implemeting the DebateSerializer (as it was until now), I prefer to just inherit from it, as it is cleaner and there shouldn't be any field that could leak from the admin panel (such as answers/costs in Proposals). I also removed the author information, as we mentioned in Update DownloadYourData exports for decidim-conferences #13859, i don't see any reason to have them (the participant that is requesting these files is the author, so they know who they are)

📌 Related Issues

Testing

  • Everything should be green
  • There shouldn't be new fields to add here

♥️ Thank you!

@andreslucena
Copy link
Copy Markdown
Member Author

andreslucena commented Jan 22, 2025

@alecslupu I thought about de-duplicating the specs (as you'll see that are like 90% similarly), but I prefer to have a bit of duplication in these case, as this 10% of differences make sense to me (like the author that I was mentioning).

Let me know if you like this approach so I can move forward with other models.

Bear in mind that the ones that we've made until now (#13858 and #13859) are actually good because they aren't duplicated with other Serializers.

@andreslucena andreslucena changed the title Simplify DebateSerializer by renaming debate to resource Update DownloadYourData exports for decidim-debates Jan 22, 2025
@andreslucena andreslucena mentioned this pull request Jan 22, 2025
Closed
22 tasks
github-actions[bot]
github-actions bot previously approved these changes Jan 22, 2025
View reviewed changes
@alecslupu
Copy link
Copy Markdown
Contributor

alecslupu commented Jan 23, 2025

@alecslupu I thought about de-duplicating the specs (as you'll see that are like 90% similarly), but I prefer to have a bit of duplication in these case, as this 10% of differences make sense to me (like the author that I was mentioning).

Let me know if you like this approach so I can move forward with other models.

Bear in mind that the ones that we've made until now (#13858 and #13859) are actually good because they aren't duplicated with other Serializers.

TBH, i have see that nonsense in the serializers ... and i fully agree with what you're doing here. Let me know if you want to make a bundle (add to this PR) or smaller PRs

@andreslucena
Copy link
Copy Markdown
Member Author

andreslucena commented Jan 23, 2025

Let me know if you want to make a bundle (add to this PR) or smaller PRs

Let's do it with smaller PRs

alecslupu
alecslupu approved these changes Jan 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Merging with codecov failure

@alecslupu alecslupu merged commit c599d2b into develop Jan 23, 2025
@alecslupu alecslupu deleted the feature/download-your-data/debates branch January 23, 2025 12:59
entantoencuanto added a commit that referenced this pull request Jan 24, 2025
@entantoencuanto
Merge branch 'develop' into staging-lot2
bd5971f 
* develop: (30 commits)
  Change hardcoded english in seeds (#13917)
  Allow importing accountability results from a Proposals component (#13817)
  Remove user interests (#13910)
  Move remaining categories from some resources to taxonomies (#13838)
  Fix translation issue on import projects mailer (#13894)
  Update DownloadYourData exports for decidim-debates (#13895)
  Allow admins to publish the questions' answers in surveys (#13786)
  Fix flaky spec in autocomplete (#13901)
  Refine taxonomy filters (part 2) (#13725)
  Fix single attachment with title (#13795)
  Fix incorrect breadcrumb encoding on mobile and tablet (#13891)
  Add string for unpublish survey admin log message (#13890)
  Fix ux meeting date location (#13872)
  New Crowdin updates (#13767)
  Fix deleted user error in schema (#13681)
  Remove assembly types from user interaction (#13881)
  Remove participatory process types from user interaction (#13880)
  Lock concurrent-ruby to 1.3.4 (#13879)
  Fix taxonomy serialization for export/imports (#13857)
  Adjust form upload label changes (#13836)
  ...
This was referenced Jan 28, 2025
Merged
Merged
Merged
antopalidi pushed a commit to openpoke/decidim that referenced this pull request Feb 12, 2025
@andreslucena @antopalidi
Update DownloadYourData exports for decidim-debates (decidim#13895)
0d87a09
andreslucena added a commit that referenced this pull request Mar 3, 2025
@andreslucena
Update DownloadYourData exports for decidim-debates (#13895)
cf28ee2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

+1 more reviewer

@alecslupu alecslupu alecslupu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: debates

Projects

No open projects
Maintainers' backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andreslucena @alecslupu