Fix translation issue on import projects mailer#13894
Merged
andreslucena merged 1 commit intodevelopfrom Jan 23, 2025
Merged
Conversation
Member
andreslucena
left a comment
There was a problem hiding this comment.
Should we add a spec for this? I have doubts, as it could mean that we probably should add specs for "not English language" in practically all the spec, so we'd be practically duplicating the specs workflows and so on... What do you think?
Contributor
Author
I have not added a spec on this fix because we would need to do the same for all the mailers. |
andreslucena
approved these changes
Jan 23, 2025
Member
andreslucena
left a comment
There was a problem hiding this comment.
As we mentioned, to add a spec would be to add 100s specs, so let's merge this as it's an improvement for sure
entantoencuanto
added a commit
that referenced
this pull request
Jan 24, 2025
* develop: (30 commits) Change hardcoded english in seeds (#13917) Allow importing accountability results from a Proposals component (#13817) Remove user interests (#13910) Move remaining categories from some resources to taxonomies (#13838) Fix translation issue on import projects mailer (#13894) Update DownloadYourData exports for decidim-debates (#13895) Allow admins to publish the questions' answers in surveys (#13786) Fix flaky spec in autocomplete (#13901) Refine taxonomy filters (part 2) (#13725) Fix single attachment with title (#13795) Fix incorrect breadcrumb encoding on mobile and tablet (#13891) Add string for unpublish survey admin log message (#13890) Fix ux meeting date location (#13872) New Crowdin updates (#13767) Fix deleted user error in schema (#13681) Remove assembly types from user interaction (#13881) Remove participatory process types from user interaction (#13880) Lock concurrent-ruby to 1.3.4 (#13879) Fix taxonomy serialization for export/imports (#13857) Adjust form upload label changes (#13836) ...
antopalidi
pushed a commit
to openpoke/decidim
that referenced
this pull request
Feb 12, 2025
andreslucena
pushed a commit
that referenced
this pull request
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While reviewing #13817, i noticed that we have a template that no matter what, tries to use the english translation. This is not OK, as there are instances where English is not configured ( for example Decidim Barcelona )
📌 Related Issues
Link your PR to an issue
Testing
Alternatively, create a new app, without English language being configured.
Seed the DB, repeat steps 2,3,4 . I am expecting that step 4 would generate an error as en is not configured.
📷 Screenshots
Please add screenshots of the changes you are proposing
