Skip to content

Change hardcoded english in seeds#13917

Merged
andreslucena merged 1 commit intodevelopfrom
fix/seeds
Jan 24, 2025
Merged

Change hardcoded english in seeds#13917
andreslucena merged 1 commit intodevelopfrom
fix/seeds

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

While investigating #13596, i have noticed that some of the proposals are being created with "en" locale, instead of Catalan.

📌 Related Issues

Link your PR to an issue

Testing

Given the app has Catalan and Spanish languages set, Catalan being default
When regenerating the development app, the seeded proposals should have the Catalan.

♥️ Thank you!

@alecslupu alecslupu added the type: internal PRs that aren't necessary to add to the CHANGELOG for implementers label Jan 23, 2025
@alecslupu alecslupu added the no-backport Pull Requests that should not be backported label Jan 23, 2025
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I didn't find any other place for this bug in the seeds. Running the seeds and checking Debates, Surveys and Proposals seem 🆗

@andreslucena andreslucena changed the title Patch i18n in seeds Change hardcoded english in seeds Jan 24, 2025
@andreslucena andreslucena merged commit bcbf41e into develop Jan 24, 2025
@andreslucena andreslucena deleted the fix/seeds branch January 24, 2025 08:47
entantoencuanto added a commit that referenced this pull request Jan 24, 2025
* develop: (30 commits)
  Change hardcoded english in seeds (#13917)
  Allow importing accountability results from a Proposals component (#13817)
  Remove user interests (#13910)
  Move remaining categories from some resources to taxonomies (#13838)
  Fix translation issue on import projects mailer (#13894)
  Update DownloadYourData exports for decidim-debates (#13895)
  Allow admins to publish the questions' answers in surveys (#13786)
  Fix flaky spec in autocomplete (#13901)
  Refine taxonomy filters (part 2) (#13725)
  Fix single attachment with title (#13795)
  Fix incorrect breadcrumb encoding on mobile and tablet (#13891)
  Add string for unpublish survey admin log message (#13890)
  Fix ux meeting date location (#13872)
  New Crowdin updates (#13767)
  Fix deleted user error in schema (#13681)
  Remove assembly types from user interaction (#13881)
  Remove participatory process types from user interaction (#13880)
  Lock concurrent-ruby to 1.3.4 (#13879)
  Fix taxonomy serialization for export/imports (#13857)
  Adjust form upload label changes (#13836)
  ...
antopalidi pushed a commit to openpoke/decidim that referenced this pull request Feb 12, 2025
andreslucena pushed a commit that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: debates module: proposals module: surveys no-backport Pull Requests that should not be backported type: fix PRs that implement a fix for a bug type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants