Skip to content

Fix meeting view when maps are disabled#13666

Merged
alecslupu merged 2 commits intodecidim:developfrom
alexrlpz:fix/meeting_view_when_maps_disabled
Dec 1, 2024
Merged

Fix meeting view when maps are disabled#13666
alecslupu merged 2 commits intodecidim:developfrom
alexrlpz:fix/meeting_view_when_maps_disabled

Conversation

@alexrlpz
Copy link
Copy Markdown
Contributor

@alexrlpz alexrlpz commented Nov 15, 2024

🎩 What? Why?

Fix "In person" meeting view when maps are configured but not enabled for that component.

📌 Related Issues

Link your PR to an issue

Testing

  1. Go to a meeting in a component with the maps enabled and see how you can see the meeting details on the meeting page.
  2. Go to the admin page and change the component configuration disabling the maps.
  3. Go back to the meeting page and see how the meeting details are still present.

📷 Screenshots

"In person" meeting with maps configured and enabled for the component:
3109f436-f7d5-4896-94d1-9e88af1c3d43

"In person" meeting with maps configured but disabled for the component (fixed view):
1d90a7c4-8cbb-4475-aeec-06aea30aca26

"Online" meetings configured and maps enabled for the component. Same screenshot for meetings configured and maps disabled:

8578be46-3051-4afe-b053-8240a6d8c46e

♥️ Thank you!

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@andreslucena andreslucena added the type: fix PRs that implement a fix for a bug label Nov 15, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 15, 2024
@fblupi fblupi changed the title Fix meeting view when maps disabled Fix meeting view when maps are disabled Nov 15, 2024
@fblupi fblupi requested a review from a team November 15, 2024 11:02
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexrlpz The fix seems to be working as expect. Can you also add some specs to highlight the fix?

@alexrlpz alexrlpz requested a review from alecslupu November 22, 2024 11:13
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit a09917b into decidim:develop Dec 1, 2024
@alecslupu alecslupu added the release: v0.29 Issues or PRs that need to be tackled for v0.29 label Dec 1, 2024
@alecslupu alecslupu added the release: v0.28 Issues or PRs that need to be tackled for v0.28 label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: meetings release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Meeting time is not present when maps are not enabled in the component

4 participants