Conversation
…e matches {}, missing required keys: [:component_id, :initiative_slug]
…itted parameters to hash
…or Symbols, got: Integer
… matches {:component_id=>1461}, missing required keys: [:initiative_slug]
…tion => [:display_conditions_for_other_questions]
andreslucena
left a comment
There was a problem hiding this comment.
I think we should give a spin to the Releases Notes, but as this will not be the final form, for now I'll ignore it and after we finish the other PRs we can retake this.
andreslucena
left a comment
There was a problem hiding this comment.
As my only pending comment is about the version change in the Releases Notes, I think it's safe to merge this 😄
Outstanding work @alecslupu, thanks for the handholding with the commit messages!
Feel free to change the branch/repository and merge this when you like. I'd wait until Monday just in case.
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
|
Merging with the expected failure of the Generators |
|
Oh I think we have a github bug on this PR:
So, basically, we have unsolved comments that can't be solved that need to be solved 🤣 I'll change the setting so I can merge this, but just a FYI for the other PR @alecslupu |
🎩 What? Why?
Attempt to upgrade the application to Rails 7.1
Before merging this, the following PRs needs to be merged:
foundation_rails_helpergem #13266Rails.application.secretsto Environment Variables #13268📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📷 Screenshots
Please add screenshots of the changes you are proposing
