Skip to content

Remove foundation_rails_helper gem#13266

Merged
andreslucena merged 4 commits intodevelopfrom
chore/remove-foundation-rails-helper
Sep 5, 2024
Merged

Remove foundation_rails_helper gem#13266
andreslucena merged 4 commits intodevelopfrom
chore/remove-foundation-rails-helper

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

Since we want to start the rails 7.1 upgrade and the foundation_rails_helper gem is not being upgraded, we integrate it with the application.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

  1. Switch to the branch, start your dev server
  2. Browse and observe the forms
  3. Compare it with the nightly
  4. See there are no changes

♥️ Thank you!

@alecslupu alecslupu added dependencies Pull requests that update a dependency file or issues that talk about updating dependencies type: removal PRs that implement a removal of a functionality or code labels Jul 31, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 31, 2024
@alecslupu alecslupu changed the title Remove foundation_rails_jelper gem Remove foundation_rails_helper gem Jul 31, 2024
@alecslupu alecslupu mentioned this pull request Jul 31, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 31, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 31, 2024
@alecslupu alecslupu marked this pull request as ready for review July 31, 2024 09:27
@alecslupu alecslupu requested a review from andreslucena July 31, 2024 09:27
@alecslupu alecslupu added this to the 0.30.0 milestone Jul 31, 2024
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it out locally and it looks good.

Just a quick copyright header update and a general note about future refactors on my side and this is ready to be merged

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes Sep 5, 2024
github-actions[bot]
github-actions bot previously approved these changes Sep 5, 2024
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@andreslucena andreslucena merged commit 4c0e92e into develop Sep 5, 2024
@andreslucena andreslucena deleted the chore/remove-foundation-rails-helper branch September 5, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

configuration dependencies Pull requests that update a dependency file or issues that talk about updating dependencies module: admin module: comments module: core module: generators module: system type: removal PRs that implement a removal of a functionality or code

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants