Migrate Rails.application.secrets to Environment Variables#13268
Merged
andreslucena merged 69 commits intodevelopfrom Apr 1, 2025
Merged
Migrate Rails.application.secrets to Environment Variables#13268andreslucena merged 69 commits intodevelopfrom
Rails.application.secrets to Environment Variables#13268andreslucena merged 69 commits intodevelopfrom
Conversation
Merged
Rails.application.secrets to Environment Variables
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Member
|
@alecslupu this one is still in the docs: Can you remove it? Or do you prefer to do that in the next PR? |
andreslucena
previously approved these changes
Mar 31, 2025
Member
andreslucena
left a comment
There was a problem hiding this comment.
As I mentioned in my last comments, there are a couple of details pending that we will fix in another PR. I'll do an issue to keep track of those details.
Approving and merging as is so we can unblock other related PRs
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
0a950ab
andreslucena
approved these changes
Apr 1, 2025
Member
|
Merging with the only failure of codecov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR is removing all the
Rails.application.secrets, as this is being deprecated in the upcoming rails 7.1 version, and is going to be removed in rails 7.2.📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
Please add screenshots of the changes you are proposing
