Switch from Rails.application.secrets to Rails.application.credentials#13220
Switch from Rails.application.secrets to Rails.application.credentials#13220
Conversation
|
Hi! As we've talked in chat, we will not move forward with this one, as I don't think the Credentials API is useful for the Decidim use-case. Basically I think we should move forward with having a Decidim installation work better wtih a docker image, and for that we should keep moving to the ENV VAR configurations style (basically what is described at https://12factor.net/config) Why I don't like Credentials for Decidim: As far as I understand how credentials work, it's adding more complexity to deployments. For us (developers) is not a problem, but for others (more junior developers, implementers that don't know much about Linux) they can be difficult to understand and work with. If the instructions say: Then you need to explain people how to work with If we need to drop the Secrets API for the update, I'll think in the best way for an update path that's compatible with what we have:
|
|
Clsoing in favor of #13268 |
🎩 What? Why?
This PR converts all
Rails.application.secretstoRails.application.credentials, in order to avoid displaying deprecation warnings once the upgrade to rails 7.1 is performed.Testing