Skip to content

Make transferable authorization when duplicate user is ephemeral#13981

Merged
alecslupu merged 3 commits intodevelopfrom
feature/ephemeral_to_regular_users
Feb 18, 2025
Merged

Make transferable authorization when duplicate user is ephemeral#13981
alecslupu merged 3 commits intodevelopfrom
feature/ephemeral_to_regular_users

Conversation

@entantoencuanto
Copy link
Copy Markdown
Contributor

@entantoencuanto entantoencuanto commented Jan 30, 2025

🎩 What? Why?

This PR makes authorizations transferable when they belong to ephemeral users and the destination user is a regular user.

📌 Related Issues

Testing

Define an ephemeral permission to vote in a budgets component. Create a budgets order as ephemeral user in the component, sign out, enter as a regular user and try to vote in the same component. After verifying the identity with the same data the order should be transferred.

Example done in https://decidim-lot2.populate.tools/processes/branch-highway/f/6/budgets/1/projects

Screencast.from.31-01-25.12.23.08.webm

♥️ Thank you!

github-actions[bot]
github-actions bot previously approved these changes Jan 30, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 30, 2025
@entantoencuanto entantoencuanto marked this pull request as ready for review January 31, 2025 09:18
@entantoencuanto
Copy link
Copy Markdown
Contributor Author

I have deleted all ephemeral authorizations and budgets orders to test easily, @NilHomedes

Copy link
Copy Markdown
Member

@NilHomedes NilHomedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected! Thanks @entantoencuanto!

@andreslucena andreslucena assigned alecslupu and unassigned NilHomedes Feb 12, 2025
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit 8728764 into develop Feb 18, 2025
@alecslupu alecslupu deleted the feature/ephemeral_to_regular_users branch February 18, 2025 10:44
entantoencuanto added a commit that referenced this pull request Feb 18, 2025
* develop:
  Change release patch instructions in Releases internal documentation (#14061)
  Suggested hashtags in Proposals (#14103)
  Make transferable authorization when duplicate user is ephemeral (#13981)
  Fix UX mobile budget page adjustements (#14028)
  Fix develop pipeline (#14104)
  New Crowdin updates (#14106)
  New Crowdin updates (#14100)
  New translations en.yml (Catalan) (#14098)
  New Crowdin updates (#14093)
  New translations en.yml (Basque) (#14090)
  New Crowdin updates (#14081)
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 9, 2025
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 10, 2025
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 11, 2025
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 11, 2025
fblupi added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request May 8, 2025
…ows features (#46)

* Improve registration and verification flow (decidim#13295)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Maxim Colls <collsmaxim@gmail.com>

* Fix title on spec for the 'Create new proposal' page (decidim#14347)

* Fix title on spec for the 'Create new proposal' page

* Fix another spec

* Remove scopes_select_field from dummy authorization form

* Fix admin pipeline with `welcome_notification_body` spec error (decidim#14475)

* Standardize direct verification for one-time participation (decidim#13579)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>

* Fix title on spec for the 'Create new proposal' page (decidim#14347)

* Fix title on spec for the 'Create new proposal' page

* Fix another spec

* Remove scope from tests

* Make transferable authorization when duplicate user is ephemeral (decidim#13981)

* Implement share and download buttons in budget successful vote screen (decidim#14283)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Extract success animation to a helper

* Fix HexaPDF dependency (decidim#13834)

* Fix HexaPDF dependency

* Fix Gemfile

* Remove reference to rqrcode

* Update decidim-generators lockfile

* Implement focus mode in the budget projects component (decidim#14512)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Allow customization of focus_mode_back_button text and path and use in projects index

* Define a setting in budgets component to enter in focus mode by default voting budgets

* Hide start voting button if voting is not available

* Hide voting progress box in project show if not in focus mode

* Consider focus mode settings in budgets lists cells

* Adapt tests

* Do not display vote text in budget list item cell if voting is not available

* Set authorization_redirect_path of project vote button to take into account focus mode

* Avoid duplication of button id

* Allow displaying close focus mode or ephemeral session on header with focus mode back button

* Adapt tests

* Add missing i18n strings from ca/es (#49)

* Use focus mode and Vote text regardless the allowed vote status

* Define budget order status view in focus mode

* Redirect to focus mode endpoints when component settings sets focus mode as default

* Fix linter offense

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Remove unused translations

* Fix tests

* Add new strings for the budgets voting phase

* Remove 'Download your vote' from the success page in Budgets

* Fix size in project's title

* Remove unused strings

* Change bold messages in the budget's voting explanation

* Change behavior of the minimum budget so it's minimum projects

* Redirect authorized vote button in projects index to the same page

* Exclude focus navigation links from exit focus warning modal behavior

* Normalize i18n on English locale and make consistent the other translations

* Fix budget detail with "You voted for this" string (decidim#14284)

* Adapt tests

* Add highlighted colors on the different states of the budgets' voting (#55)

* Add highlighted colors on the different states of the budgets' voting

* Improve the message in the finished budget voting

* Fix linter offense

* Remove share button and fix header close button (#56)

* Remove share button and center CTA

* Add title to success page

* Fix placing of the Cancel button in ephemeral/focus modes

* Remove unused strings from i18n-tasks

---------

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Maxim Colls <collsmaxim@gmail.com>
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@gmail.com>
Co-authored-by: Francisco Bolívar <francisco.bolivar@nazaries.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Convert a ephemeral user to a normal user

4 participants