Skip to content

Implement share and download buttons in budget successful vote screen#14283

Merged
alecslupu merged 10 commits intodevelopfrom
feat/finish-successfull-voting-screen
Apr 8, 2025
Merged

Implement share and download buttons in budget successful vote screen#14283
alecslupu merged 10 commits intodevelopfrom
feat/finish-successfull-voting-screen

Conversation

@mllocs
Copy link
Copy Markdown
Contributor

@mllocs mllocs commented Mar 12, 2025

🎩 What? Why?

The "Share your vote" and "Download" buttons in the successful budget voting screen were not working. This implements the following:

  • When clicking "Share your vote" you can share that you voted in the Social Media.
  • When clicking "Download" we create a signed pdf that proves that you voted the budgets.

📌 Related Issues

Testing

📷 Screenshots

CleanShot 2025-03-12 at 17 50 31@2x

CleanShot 2025-03-12 at 17 51 02@2x

CleanShot 2025-03-12 at 17 49 52@2x

♥️ Thank you!

github-actions[bot]

This comment was marked as outdated.

@mllocs mllocs self-assigned this Mar 12, 2025
github-actions[bot]
github-actions bot previously approved these changes Mar 12, 2025
github-actions[bot]
github-actions bot previously approved these changes Mar 12, 2025
github-actions[bot]
github-actions bot previously approved these changes Mar 12, 2025
@mllocs mllocs marked this pull request as ready for review March 12, 2025 16:52
@mllocs mllocs requested a review from furilo March 12, 2025 16:53
@alecslupu alecslupu moved this to 👀 In review in Maintainers' backlog Mar 13, 2025
github-actions[bot]
github-actions bot previously approved these changes Mar 14, 2025
github-actions[bot]
github-actions bot previously approved these changes Mar 14, 2025
@mllocs mllocs requested a review from NilHomedes March 14, 2025 09:18
@mllocs mllocs unassigned furilo and mllocs Mar 14, 2025
@mllocs
Copy link
Copy Markdown
Contributor Author

mllocs commented Mar 18, 2025

Looks like the Decidim::Verifications tests are failing in develop

furilo
furilo previously approved these changes Mar 18, 2025
Copy link
Copy Markdown
Contributor

@entantoencuanto entantoencuanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I think that the failing tests will be fixed if you merge develop, the fails seem to not have relation with this PR

@mllocs mllocs requested a review from alecslupu March 19, 2025 20:42
@furilo furilo requested a review from NilHomedes March 21, 2025 08:40
@alecslupu alecslupu added the project: 2024-developments Barcelona City Council contract label Mar 24, 2025
Copy link
Copy Markdown
Member

@NilHomedes NilHomedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mllocs, now LGTM! 🚀

@andreslucena
Copy link
Copy Markdown
Member

Can you fix the git conflicts @mllocs 🙏🏽 ?

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit d9bf1b3 into develop Apr 8, 2025
119 checks passed
@alecslupu alecslupu deleted the feat/finish-successfull-voting-screen branch April 8, 2025 22:18
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Maintainers' backlog Apr 8, 2025
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 10, 2025
…decidim#14283)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 11, 2025
…decidim#14283)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 11, 2025
…decidim#14283)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 11, 2025
…decidim#14283)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
fblupi added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request May 8, 2025
…ows features (#46)

* Improve registration and verification flow (decidim#13295)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Maxim Colls <collsmaxim@gmail.com>

* Fix title on spec for the 'Create new proposal' page (decidim#14347)

* Fix title on spec for the 'Create new proposal' page

* Fix another spec

* Remove scopes_select_field from dummy authorization form

* Fix admin pipeline with `welcome_notification_body` spec error (decidim#14475)

* Standardize direct verification for one-time participation (decidim#13579)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>

* Fix title on spec for the 'Create new proposal' page (decidim#14347)

* Fix title on spec for the 'Create new proposal' page

* Fix another spec

* Remove scope from tests

* Make transferable authorization when duplicate user is ephemeral (decidim#13981)

* Implement share and download buttons in budget successful vote screen (decidim#14283)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Extract success animation to a helper

* Fix HexaPDF dependency (decidim#13834)

* Fix HexaPDF dependency

* Fix Gemfile

* Remove reference to rqrcode

* Update decidim-generators lockfile

* Implement focus mode in the budget projects component (decidim#14512)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Allow customization of focus_mode_back_button text and path and use in projects index

* Define a setting in budgets component to enter in focus mode by default voting budgets

* Hide start voting button if voting is not available

* Hide voting progress box in project show if not in focus mode

* Consider focus mode settings in budgets lists cells

* Adapt tests

* Do not display vote text in budget list item cell if voting is not available

* Set authorization_redirect_path of project vote button to take into account focus mode

* Avoid duplication of button id

* Allow displaying close focus mode or ephemeral session on header with focus mode back button

* Adapt tests

* Add missing i18n strings from ca/es (#49)

* Use focus mode and Vote text regardless the allowed vote status

* Define budget order status view in focus mode

* Redirect to focus mode endpoints when component settings sets focus mode as default

* Fix linter offense

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Remove unused translations

* Fix tests

* Add new strings for the budgets voting phase

* Remove 'Download your vote' from the success page in Budgets

* Fix size in project's title

* Remove unused strings

* Change bold messages in the budget's voting explanation

* Change behavior of the minimum budget so it's minimum projects

* Redirect authorized vote button in projects index to the same page

* Exclude focus navigation links from exit focus warning modal behavior

* Normalize i18n on English locale and make consistent the other translations

* Fix budget detail with "You voted for this" string (decidim#14284)

* Adapt tests

* Add highlighted colors on the different states of the budgets' voting (#55)

* Add highlighted colors on the different states of the budgets' voting

* Improve the message in the finished budget voting

* Fix linter offense

* Remove share button and fix header close button (#56)

* Remove share button and center CTA

* Add title to success page

* Fix placing of the Cancel button in ephemeral/focus modes

* Remove unused strings from i18n-tasks

---------

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Maxim Colls <collsmaxim@gmail.com>
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@gmail.com>
Co-authored-by: Francisco Bolívar <francisco.bolivar@nazaries.com>
@alecslupu alecslupu added this to the 0.31.0 milestone Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Finish succesfull voting screen

6 participants