Implement share and download buttons in budget successful vote screen#14283
Merged
Implement share and download buttons in budget successful vote screen#14283
Conversation
Contributor
Author
|
Looks like the |
furilo
previously approved these changes
Mar 18, 2025
entantoencuanto
previously approved these changes
Mar 19, 2025
Contributor
entantoencuanto
left a comment
There was a problem hiding this comment.
Great work! I think that the failing tests will be fixed if you merge develop, the fails seem to not have relation with this PR
NilHomedes
approved these changes
Mar 24, 2025
Member
NilHomedes
left a comment
There was a problem hiding this comment.
Thanks, @mllocs, now LGTM! 🚀
Member
|
Can you fix the git conflicts @mllocs 🙏🏽 ? |
cea409b
entantoencuanto
added a commit
to AjuntamentdeBarcelona/decidim
that referenced
this pull request
Apr 10, 2025
…decidim#14283) Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
entantoencuanto
added a commit
to AjuntamentdeBarcelona/decidim
that referenced
this pull request
Apr 11, 2025
…decidim#14283) Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
entantoencuanto
added a commit
to AjuntamentdeBarcelona/decidim
that referenced
this pull request
Apr 11, 2025
…decidim#14283) Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
entantoencuanto
added a commit
to AjuntamentdeBarcelona/decidim
that referenced
this pull request
Apr 11, 2025
…decidim#14283) Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
fblupi
added a commit
to AjuntamentdeBarcelona/decidim
that referenced
this pull request
May 8, 2025
…ows features (#46) * Improve registration and verification flow (decidim#13295) Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> Co-authored-by: Maxim Colls <collsmaxim@gmail.com> * Fix title on spec for the 'Create new proposal' page (decidim#14347) * Fix title on spec for the 'Create new proposal' page * Fix another spec * Remove scopes_select_field from dummy authorization form * Fix admin pipeline with `welcome_notification_body` spec error (decidim#14475) * Standardize direct verification for one-time participation (decidim#13579) Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com> * Fix title on spec for the 'Create new proposal' page (decidim#14347) * Fix title on spec for the 'Create new proposal' page * Fix another spec * Remove scope from tests * Make transferable authorization when duplicate user is ephemeral (decidim#13981) * Implement share and download buttons in budget successful vote screen (decidim#14283) Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Extract success animation to a helper * Fix HexaPDF dependency (decidim#13834) * Fix HexaPDF dependency * Fix Gemfile * Remove reference to rqrcode * Update decidim-generators lockfile * Implement focus mode in the budget projects component (decidim#14512) Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Allow customization of focus_mode_back_button text and path and use in projects index * Define a setting in budgets component to enter in focus mode by default voting budgets * Hide start voting button if voting is not available * Hide voting progress box in project show if not in focus mode * Consider focus mode settings in budgets lists cells * Adapt tests * Do not display vote text in budget list item cell if voting is not available * Set authorization_redirect_path of project vote button to take into account focus mode * Avoid duplication of button id * Allow displaying close focus mode or ephemeral session on header with focus mode back button * Adapt tests * Add missing i18n strings from ca/es (#49) * Use focus mode and Vote text regardless the allowed vote status * Define budget order status view in focus mode * Redirect to focus mode endpoints when component settings sets focus mode as default * Fix linter offense Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Remove unused translations * Fix tests * Add new strings for the budgets voting phase * Remove 'Download your vote' from the success page in Budgets * Fix size in project's title * Remove unused strings * Change bold messages in the budget's voting explanation * Change behavior of the minimum budget so it's minimum projects * Redirect authorized vote button in projects index to the same page * Exclude focus navigation links from exit focus warning modal behavior * Normalize i18n on English locale and make consistent the other translations * Fix budget detail with "You voted for this" string (decidim#14284) * Adapt tests * Add highlighted colors on the different states of the budgets' voting (#55) * Add highlighted colors on the different states of the budgets' voting * Improve the message in the finished budget voting * Fix linter offense * Remove share button and fix header close button (#56) * Remove share button and center CTA * Add title to success page * Fix placing of the Cancel button in ephemeral/focus modes * Remove unused strings from i18n-tasks --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> Co-authored-by: Maxim Colls <collsmaxim@gmail.com> Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@gmail.com> Co-authored-by: Francisco Bolívar <francisco.bolivar@nazaries.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The "Share your vote" and "Download" buttons in the successful budget voting screen were not working. This implements the following:
📌 Related Issues
Testing
📷 Screenshots