Skip to content

Fix admin pipeline with welcome_notification_body spec error#14475

Merged
andreslucena merged 1 commit intodevelopfrom
chore/admin-failing-pipeline
Apr 8, 2025
Merged

Fix admin pipeline with welcome_notification_body spec error#14475
andreslucena merged 1 commit intodevelopfrom
chore/admin-failing-pipeline

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

We have noticed that the admin pipeline is failing with some error related to the field not being updated properly. This PR fixes that.

The error was caused by the admin form being already filled in, which caused the added value to be added as a plain div ( no actual text) within the editor.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

image

♥️ Thank you!

@github-actions github-actions bot added module: dev type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Apr 7, 2025
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@greenwoodt greenwoodt added release: v0.29 Issues or PRs that need to be tackled for v0.29 release: v0.30 Issues or PRs that need to be tackled for v0.30 labels Apr 7, 2025
@alecslupu alecslupu added the type: fix PRs that implement a fix for a bug label Apr 7, 2025
@alecslupu alecslupu marked this pull request as ready for review April 7, 2025 12:05
Copy link
Copy Markdown
Member

@greenwoodt greenwoodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline is green, handing over to @andreslucena to review and merge!

@alecslupu alecslupu added the release: v0.28 Issues or PRs that need to be tackled for v0.28 label Apr 7, 2025
@andreslucena andreslucena changed the title Fix admin pipeline Fix admin pipeline with welcome_notification_body spec error Apr 8, 2025
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this is indeed solving the failure.

To be honest, I don't fully understand what's happening here (like what changed in the CI env or code that generated this problem, nor why is it only happening in this particular spec and not in the rest).

As it isn't a behavior that I'm seeing outside of specs and this is blocking us for other PRs, I'm giving it a green.

@andreslucena
Copy link
Copy Markdown
Member

why is it only happening in this particular spec and not in the rest

Talking with @alecslupu in Telegram he mentioned that "maybe because in the other places the editor content doesnt have any data" (in this particular field we already have some default contents before the edition)

entantoencuanto pushed a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 11, 2025
fblupi added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request May 8, 2025
…ows features (#46)

* Improve registration and verification flow (decidim#13295)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Maxim Colls <collsmaxim@gmail.com>

* Fix title on spec for the 'Create new proposal' page (decidim#14347)

* Fix title on spec for the 'Create new proposal' page

* Fix another spec

* Remove scopes_select_field from dummy authorization form

* Fix admin pipeline with `welcome_notification_body` spec error (decidim#14475)

* Standardize direct verification for one-time participation (decidim#13579)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>

* Fix title on spec for the 'Create new proposal' page (decidim#14347)

* Fix title on spec for the 'Create new proposal' page

* Fix another spec

* Remove scope from tests

* Make transferable authorization when duplicate user is ephemeral (decidim#13981)

* Implement share and download buttons in budget successful vote screen (decidim#14283)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Extract success animation to a helper

* Fix HexaPDF dependency (decidim#13834)

* Fix HexaPDF dependency

* Fix Gemfile

* Remove reference to rqrcode

* Update decidim-generators lockfile

* Implement focus mode in the budget projects component (decidim#14512)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Allow customization of focus_mode_back_button text and path and use in projects index

* Define a setting in budgets component to enter in focus mode by default voting budgets

* Hide start voting button if voting is not available

* Hide voting progress box in project show if not in focus mode

* Consider focus mode settings in budgets lists cells

* Adapt tests

* Do not display vote text in budget list item cell if voting is not available

* Set authorization_redirect_path of project vote button to take into account focus mode

* Avoid duplication of button id

* Allow displaying close focus mode or ephemeral session on header with focus mode back button

* Adapt tests

* Add missing i18n strings from ca/es (#49)

* Use focus mode and Vote text regardless the allowed vote status

* Define budget order status view in focus mode

* Redirect to focus mode endpoints when component settings sets focus mode as default

* Fix linter offense

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Remove unused translations

* Fix tests

* Add new strings for the budgets voting phase

* Remove 'Download your vote' from the success page in Budgets

* Fix size in project's title

* Remove unused strings

* Change bold messages in the budget's voting explanation

* Change behavior of the minimum budget so it's minimum projects

* Redirect authorized vote button in projects index to the same page

* Exclude focus navigation links from exit focus warning modal behavior

* Normalize i18n on English locale and make consistent the other translations

* Fix budget detail with "You voted for this" string (decidim#14284)

* Adapt tests

* Add highlighted colors on the different states of the budgets' voting (#55)

* Add highlighted colors on the different states of the budgets' voting

* Improve the message in the finished budget voting

* Fix linter offense

* Remove share button and fix header close button (#56)

* Remove share button and center CTA

* Add title to success page

* Fix placing of the Cancel button in ephemeral/focus modes

* Remove unused strings from i18n-tasks

---------

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Maxim Colls <collsmaxim@gmail.com>
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@gmail.com>
Co-authored-by: Francisco Bolívar <francisco.bolivar@nazaries.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky spec module: dev release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 release: v0.30 Issues or PRs that need to be tackled for v0.30 type: fix PRs that implement a fix for a bug type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants