Improve registration and verification flow by entantoencuanto · Pull Request #13295 · decidim/decidim

entantoencuanto · 2024-08-21T11:54:21Z

🎩 What? Why?

This PR improves the verification and registration flow when a user or visitant tries to make an action which requires at least one verification:

Allows to store in the user extra data information about the action, resource with pending verifications. Some more data can be stored if required, the path to redirect after completing the verification flow and the permissions holder for actions not related with a specific resource of a component (for example, actions of initiatives or create resource action in a component)
Changes the first login page to display the status of the verifications required to allow the pending action
If a visitant is not signed in, after signing in or signing up and confirming email is redirected to the pending action onboarding page with the verifications required to authorize the action
If there are more than one verification required to authorize an action after clicking on the button or link related to the action the user is redirected to the pending action onboarding and redirected to the same page after completing each verification if there are remaining pending verifications.
After completing all the verifications if the action is authorized the user is redirected to the redirect path stored in its onboarding extended data or the resource path if the redirect path is missing with a success flash message
If any check implies that the user does not have permission to perform the action, he is redirected to the resource with a forbidden action message.
When the user browses the application and has an action pending of one or more authorizations a callout message appears with a link to complete the authorization flow
The user is allowed to remove the data about the pending authorization flow if closes the callout message.
Changes the authorized_to method to prepend a "Verify your account to ..." in the text of the button or link if not provided via block

📌 Related Issues

Link your PR to an issue

Fixes Improve registration and verification flow #13038

Testing

As admin edit the permissions of a resource (https://decidim-lot2.populate.tools/admin/participatory_processes/branch-highway/components/5/permissions/edit?resource_id=19&resource_name=meeting)
As user visit the resource (https://decidim-lot2.populate.tools/processes/branch-highway/f/5/meetings/19). If the action is not authorized yet the message should display a "Verify your account to..." When clicking on the action the user is redirected to the verifications flow page of the action (if there are more than one verification required to complete the action)
If the user has an action with verifications pending a callout is shown with a link to the authorizations flow
The authorizations page for the action shows the authorizations required to complete the action with the status of each one (https://decidim-lot2.populate.tools/authorizations/first_login). If the user gets all the pending authorizations or completes a verification and authorization is rejected the pending flow is removed and the user is redirected to the resource with a success / failure message

♥️ Thank you!

The resource locator fails trying to generate the path of a project without including the budget it belongs to. The error is fixed by including the redirect_path for onboarding directly as data attribute

There are no pending steps if authorizations count is 0 or the action is unauthorized

…n-flow * develop: Update UI design of detail page (#13356) Fix newsletter subscriber count (#13471) Fix editor image routing (#12683) Fix issues with the budgets proposals import (#12655) Fix initiative form is not taking into account the scope selected (#13598) Enable geolocation for address field in proposal form (#13423)

ResourceLocatorPresenter fails trying to generate the path of some resources like projects in budgets. This commit avoids the exceptions produced

entantoencuanto · 2024-11-18T18:07:41Z

Hi, @alecslupu , I think this PR is ready to review. I'm working on a PR which depends on it and I'm going to start with other depending on the new one. Over the past few days I've added a few commits that fix bugs and solved conflicts with develop, but the overall behavior of the functionality has remained the same.

alecslupu

If the "example authorization" is being set like this:

Then the meeting page will raise the following error:

.github/workflows/test_app.yml

decidim-comments/app/cells/decidim/comments/comment_cell.rb

decidim-comments/app/cells/decidim/comments/comments_cell.rb

entantoencuanto · 2024-11-21T11:14:57Z

If the "example authorization" is being set like this:

Then the meeting page will raise the following error:

Yes, it's a bug of the dummy authorization handler when no scope is selected. I have fixed it in the next PR #13579 but I can cherry-pick the fix

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

alecslupu · 2024-12-04T05:32:27Z

While reviewing the functionality, when I have a meeting with external registratiions enabled, and when I click on "Register" i am being redirected to authorization screen, and after filling in the authorization data, i am being redirected to external website.

IMO, if the meeting has an external registration url, maybe we could bypass the authorization? I would really like to know @decidim/product on this matter :)

alecslupu

Looks Promissing. A few small changes / things to clarify.

87 / 87

decidim-core/app/views/layouts/decidim/_wrapper.html.erb

decidim-core/app/services/decidim/onboarding_manager.rb

decidim-initiatives/spec/system/initiative_signing_spec.rb

...im-verifications/app/views/decidim/verifications/id_documents/authorizations/choose.html.erb

decidim-verifications/spec/system/action_authorization_spec.rb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

alecslupu

LGTM!

Merging with Codecov pipeline failed.

entantoencuanto added type: feature project: 2024-developments Barcelona City Council contract labels Aug 21, 2024

probot-autolabeler bot added javascript Pull requests that update Javascript code module: comments module: core module: meetings module: verifications labels Aug 21, 2024