Fix newsletter subscriber count#13471
Merged
andreslucena merged 5 commits intodevelopfrom Nov 6, 2024
Merged
Conversation
…ter-subscriber-count
Member
|
@alecslupu can you add a spec for this? Probably in somewhere like |
…ter-subscriber-count
Contributor
Author
Done in 8898901 |
andreslucena
approved these changes
Nov 6, 2024
Member
andreslucena
left a comment
There was a problem hiding this comment.
I can confirm locally the bug and the fix. Thanks for the PR!
This was referenced Nov 6, 2024
entantoencuanto
added a commit
that referenced
this pull request
Nov 6, 2024
…n-flow * develop: Update UI design of detail page (#13356) Fix newsletter subscriber count (#13471) Fix editor image routing (#12683) Fix issues with the budgets proposals import (#12655) Fix initiative form is not taking into account the scope selected (#13598) Enable geolocation for address field in proposal form (#13423)
entantoencuanto
added a commit
that referenced
this pull request
Nov 6, 2024
…eature/ephemeral-verifications * feat/improve-registration-and-verification-flow: Update UI design of detail page (#13356) Fix newsletter subscriber count (#13471) Fix editor image routing (#12683) Fix issues with the budgets proposals import (#12655) Fix initiative form is not taking into account the scope selected (#13598) Enable geolocation for address field in proposal form (#13423)
entantoencuanto
added a commit
that referenced
this pull request
Nov 6, 2024
…taging-lot2 * feat/improve-registration-and-verification-flow: Update UI design of detail page (#13356) Fix newsletter subscriber count (#13471) Fix editor image routing (#12683) Fix issues with the budgets proposals import (#12655) Fix initiative form is not taking into account the scope selected (#13598)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
while reviewing #13429 , i have noticed there is a javascript error in the page.
On a closer look, i have found that the respective javascript is related to the recipients counter, which was not updated.
📌 Related Issues
Link your PR to an issue
Testing