Dropdown select scopes on Newsletters #13429
Merged
alecslupu merged 6 commits intodecidim:developfrom Sep 30, 2024
Merged
Conversation
alecslupu
suggested changes
Sep 28, 2024
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
Almost there!
The fix works as intended, but i feel like we could add some improvements
We could improve the UI so that we can select multiple scopes ( as previous interface allowed it )
decidim-admin/app/views/decidim/admin/newsletters/select_recipients_to_deliver.html.erb
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The select dropdown for Newsletters was not migrated properly. This PR utilises the
scopes_select_fieldto fix that issue.📌 Related Issues
Testing
📷 Screenshots