Fix issues with the budgets proposals import#12655
Merged
Conversation
- Fix the scope selection with the proposals to projects import - Do not import proposal if it is already imported to another budget within the same component - Only import published and visible proposals
Contributor
|
This may be related #10168 |
This was referenced Nov 5, 2024
entantoencuanto
added a commit
that referenced
this pull request
Nov 6, 2024
…n-flow * develop: Update UI design of detail page (#13356) Fix newsletter subscriber count (#13471) Fix editor image routing (#12683) Fix issues with the budgets proposals import (#12655) Fix initiative form is not taking into account the scope selected (#13598) Enable geolocation for address field in proposal form (#13423)
entantoencuanto
added a commit
that referenced
this pull request
Nov 6, 2024
…eature/ephemeral-verifications * feat/improve-registration-and-verification-flow: Update UI design of detail page (#13356) Fix newsletter subscriber count (#13471) Fix editor image routing (#12683) Fix issues with the budgets proposals import (#12655) Fix initiative form is not taking into account the scope selected (#13598) Enable geolocation for address field in proposal form (#13423)
entantoencuanto
added a commit
that referenced
this pull request
Nov 6, 2024
…taging-lot2 * feat/improve-registration-and-verification-flow: Update UI design of detail page (#13356) Fix newsletter subscriber count (#13471) Fix editor image routing (#12683) Fix issues with the budgets proposals import (#12655) Fix initiative form is not taking into account the scope selected (#13598)
ahukkanen
added a commit
to mainio/decidim-module-patches
that referenced
this pull request
Mar 11, 2025
Fixes the following issue for 0.27: decidim/decidim#12655
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The issue was noticed when importing proposals to projects and using the scope selection. There has been an oversight with the migration done at #8669 as this case was not covered by the specs.
This issue can be seen when the following situation is applied:
At the same time, I also noticed few other improvements that are implemented in this PR (see the list above).
📌 Related Issues
VirtustoActiveModel::Attributes(and get rid ofRectify::Form) #8669Testing