Skip to content

Fix issues with the budgets proposals import#12655

Merged
alecslupu merged 1 commit intodevelopfrom
fix/budgets-project-import-scope
Nov 5, 2024
Merged

Fix issues with the budgets proposals import#12655
alecslupu merged 1 commit intodevelopfrom
fix/budgets-project-import-scope

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

🎩 What? Why?

  • Fix the scope selection with the proposals to projects import
  • Do not import proposal if it is already imported to another budget within the same component
  • Only import published and visible proposals

The issue was noticed when importing proposals to projects and using the scope selection. There has been an oversight with the migration done at #8669 as this case was not covered by the specs.

This issue can be seen when the following situation is applied:

  • The participatory process has a scope defined
  • Scopes are enabled for the budgets component and the default scope is the one defined for the process
  • Importing proposals to projects will only import the proposals mapped to the default scope regardless of what was selected from the scopes selector

At the same time, I also noticed few other improvements that are implemented in this PR (see the list above).

📌 Related Issues

Testing

  • Create a top scope and some sub-scopes under it
  • Create a participatory process and enable the top scope for the process
  • Create proposals component and enable the top scope for the component
  • Add some proposals to the component and pick scopes for them
  • Evaluate some of the proposals as accepted
  • Create a budgets component and enable the top scope for the component
  • Create 2 budgets with different scopes than the top scope (i.e. one of the subscopes)
    • Make sure you have proposals mapped to those subscopes
  • Import proposals to either one of these budgets by selecting the correct scope for them (i.e. the same scope that is defined for that budget)
  • Import the proposals
  • See that incorrect proposals were imported

- Fix the scope selection with the proposals to projects import
- Do not import proposal if it is already imported to another
  budget within the same component
- Only import published and visible proposals
@ahukkanen ahukkanen added module: budgets type: fix PRs that implement a fix for a bug labels Mar 29, 2024
@alecslupu alecslupu self-assigned this Apr 15, 2024
@alecslupu
Copy link
Copy Markdown
Contributor

This may be related #10168

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu added release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 labels Nov 5, 2024
@alecslupu alecslupu added this to the 0.30.0 milestone Nov 5, 2024
@alecslupu alecslupu merged commit 88a904d into develop Nov 5, 2024
@alecslupu alecslupu deleted the fix/budgets-project-import-scope branch November 5, 2024 09:32
@alecslupu alecslupu added release: v0.29 Issues or PRs that need to be tackled for v0.29 and removed release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 labels Nov 5, 2024
entantoencuanto added a commit that referenced this pull request Nov 6, 2024
…n-flow

* develop:
  Update UI design of detail page (#13356)
  Fix newsletter subscriber count (#13471)
  Fix editor image routing (#12683)
  Fix issues with the budgets proposals import (#12655)
  Fix initiative form is not taking into account the scope selected (#13598)
  Enable geolocation for address field in proposal form (#13423)
entantoencuanto added a commit that referenced this pull request Nov 6, 2024
…eature/ephemeral-verifications

* feat/improve-registration-and-verification-flow:
  Update UI design of detail page (#13356)
  Fix newsletter subscriber count (#13471)
  Fix editor image routing (#12683)
  Fix issues with the budgets proposals import (#12655)
  Fix initiative form is not taking into account the scope selected (#13598)
  Enable geolocation for address field in proposal form (#13423)
entantoencuanto added a commit that referenced this pull request Nov 6, 2024
…taging-lot2

* feat/improve-registration-and-verification-flow:
  Update UI design of detail page (#13356)
  Fix newsletter subscriber count (#13471)
  Fix editor image routing (#12683)
  Fix issues with the budgets proposals import (#12655)
  Fix initiative form is not taking into account the scope selected (#13598)
ahukkanen added a commit to mainio/decidim-module-patches that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: budgets release: v0.29 Issues or PRs that need to be tackled for v0.29 type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants