Merged
Conversation
In order to store the blob references in the database correctly so that we can regenerate the URLs.
Anything that uses the SettingsManifest can also have rich text content where the blob replacement logic has to be applied at.
entantoencuanto
added a commit
that referenced
this pull request
Nov 6, 2024
…n-flow * develop: Update UI design of detail page (#13356) Fix newsletter subscriber count (#13471) Fix editor image routing (#12683) Fix issues with the budgets proposals import (#12655) Fix initiative form is not taking into account the scope selected (#13598) Enable geolocation for address field in proposal form (#13423)
entantoencuanto
added a commit
that referenced
this pull request
Nov 6, 2024
…eature/ephemeral-verifications * feat/improve-registration-and-verification-flow: Update UI design of detail page (#13356) Fix newsletter subscriber count (#13471) Fix editor image routing (#12683) Fix issues with the budgets proposals import (#12655) Fix initiative form is not taking into account the scope selected (#13598) Enable geolocation for address field in proposal form (#13423)
entantoencuanto
added a commit
that referenced
this pull request
Nov 6, 2024
…taging-lot2 * feat/improve-registration-and-verification-flow: Update UI design of detail page (#13356) Fix newsletter subscriber count (#13471) Fix editor image routing (#12683) Fix issues with the budgets proposals import (#12655) Fix initiative form is not taking into account the scope selected (#13598)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While implementing #12576, there was one problem regarding the blob URLs that are persisted to the database which is that they cannot be created dynamically at render time because the HTML is persisted to the database as-is.
This fixes the issue by replacing references to any blob URLs with the blob's global ID and then swapping it back to the actual URL when these values are rendered.
This fixes two issues:
This also changes the signed blob URL expiry period to 7 days which is the maximum set by Amazon S3 and Google Cloud Files. This has to be used together with a sensible caching strategy as the expiry periods of these 3rd party services cannot be extended. In other words, when using Amazon S3 or Google Cloud Files, the cache has to be cleared at least once every 7 days because e.g. the content block cache is set to expire never.
📌 Related Issues
Link your PR to an issue
Testing
srcattribute replaced withgid://decidim-development-app/ActiveStorage::Blob/XYZ(where XYZ is the blob ID in the database)