Skip to content

Fix title on spec for the 'Create new proposal' page#14347

Merged
alecslupu merged 2 commits intodevelopfrom
fix/action-authorization-spec
Mar 18, 2025
Merged

Fix title on spec for the 'Create new proposal' page#14347
alecslupu merged 2 commits intodevelopfrom
fix/action-authorization-spec

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

After we merged #14110, we have a new failing spec in develop. This PR fixes it.

Testing

Everything should be green

♥️ Thank you!

@github-actions github-actions bot added module: verifications type: fix PRs that implement a fix for a bug labels Mar 18, 2025
@andreslucena andreslucena force-pushed the fix/action-authorization-spec branch from a8fcf82 to be33d86 Compare March 18, 2025 15:22
@andreslucena andreslucena changed the title Fix title for 'Create new proposal' page Fix title on spec for the 'Create new proposal' page Mar 18, 2025
alecslupu
alecslupu previously approved these changes Mar 18, 2025
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu added release: v0.30 Issues or PRs that need to be tackled for v0.30 release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 labels Mar 18, 2025
@alecslupu alecslupu self-assigned this Mar 18, 2025
github-actions[bot]
github-actions bot previously approved these changes Mar 18, 2025
@alecslupu
Copy link
Copy Markdown
Contributor

@andreslucena it seems there are more places where this change is needed.

@andreslucena
Copy link
Copy Markdown
Member Author

@andreslucena it seems there are more places where this change is needed.

I'm on it boss

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit 516e977 into develop Mar 18, 2025
51 checks passed
@alecslupu alecslupu deleted the fix/action-authorization-spec branch March 18, 2025 19:32
@alecslupu alecslupu removed release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 labels Mar 18, 2025
@alecslupu alecslupu added the release: v0.29 Issues or PRs that need to be tackled for v0.29 label Mar 18, 2025
entantoencuanto added a commit that referenced this pull request Mar 20, 2025
* feature/signature_workflows:
  Add documentation for signature handler encryption secret and rename environment variable
  Rename method
  Fix title on spec for the 'Create new proposal' page (#14347)
  Fix WCAG search filters navigation (#14014)
  Fix comment cell to not show reply button when passing MAX_DEPTH (#14291)
  Fix editing comment with max length setting (#14275)
  Add title tag on pages for blogs, debates and meetings (#14110)
  Fix white bottom on proposal show with voting (#14285)
  New Crowdin updates (#14318)
  New Crowdin updates (#14217)
  Fix image missing error (#14175)
  Add delay of `spam_analysis` queue (#14304)
  Fix hide comment from interface (#14301)
  Change "Valuator" for "Evaluator" (#13684)
  Fix QR code generation (#14300)
  Patch backporter action (#14292)
  Change `hide_voting` argument on proposal cell to `show_voting` (#14267)
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 9, 2025
* Fix title on spec for the 'Create new proposal' page

* Fix another spec
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 9, 2025
* Fix title on spec for the 'Create new proposal' page

* Fix another spec
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 9, 2025
* Fix title on spec for the 'Create new proposal' page

* Fix another spec
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 9, 2025
* Fix title on spec for the 'Create new proposal' page

* Fix another spec
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 10, 2025
* Fix title on spec for the 'Create new proposal' page

* Fix another spec
entantoencuanto added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Apr 11, 2025
* Fix title on spec for the 'Create new proposal' page

* Fix another spec
fblupi added a commit to AjuntamentdeBarcelona/decidim that referenced this pull request May 8, 2025
…ows features (#46)

* Improve registration and verification flow (decidim#13295)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Maxim Colls <collsmaxim@gmail.com>

* Fix title on spec for the 'Create new proposal' page (decidim#14347)

* Fix title on spec for the 'Create new proposal' page

* Fix another spec

* Remove scopes_select_field from dummy authorization form

* Fix admin pipeline with `welcome_notification_body` spec error (decidim#14475)

* Standardize direct verification for one-time participation (decidim#13579)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>

* Fix title on spec for the 'Create new proposal' page (decidim#14347)

* Fix title on spec for the 'Create new proposal' page

* Fix another spec

* Remove scope from tests

* Make transferable authorization when duplicate user is ephemeral (decidim#13981)

* Implement share and download buttons in budget successful vote screen (decidim#14283)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Extract success animation to a helper

* Fix HexaPDF dependency (decidim#13834)

* Fix HexaPDF dependency

* Fix Gemfile

* Remove reference to rqrcode

* Update decidim-generators lockfile

* Implement focus mode in the budget projects component (decidim#14512)

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Allow customization of focus_mode_back_button text and path and use in projects index

* Define a setting in budgets component to enter in focus mode by default voting budgets

* Hide start voting button if voting is not available

* Hide voting progress box in project show if not in focus mode

* Consider focus mode settings in budgets lists cells

* Adapt tests

* Do not display vote text in budget list item cell if voting is not available

* Set authorization_redirect_path of project vote button to take into account focus mode

* Avoid duplication of button id

* Allow displaying close focus mode or ephemeral session on header with focus mode back button

* Adapt tests

* Add missing i18n strings from ca/es (#49)

* Use focus mode and Vote text regardless the allowed vote status

* Define budget order status view in focus mode

* Redirect to focus mode endpoints when component settings sets focus mode as default

* Fix linter offense

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Remove unused translations

* Fix tests

* Add new strings for the budgets voting phase

* Remove 'Download your vote' from the success page in Budgets

* Fix size in project's title

* Remove unused strings

* Change bold messages in the budget's voting explanation

* Change behavior of the minimum budget so it's minimum projects

* Redirect authorized vote button in projects index to the same page

* Exclude focus navigation links from exit focus warning modal behavior

* Normalize i18n on English locale and make consistent the other translations

* Fix budget detail with "You voted for this" string (decidim#14284)

* Adapt tests

* Add highlighted colors on the different states of the budgets' voting (#55)

* Add highlighted colors on the different states of the budgets' voting

* Improve the message in the finished budget voting

* Fix linter offense

* Remove share button and fix header close button (#56)

* Remove share button and center CTA

* Add title to success page

* Fix placing of the Cancel button in ephemeral/focus modes

* Remove unused strings from i18n-tasks

---------

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Maxim Colls <collsmaxim@gmail.com>
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@gmail.com>
Co-authored-by: Francisco Bolívar <francisco.bolivar@nazaries.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: verifications release: v0.29 Issues or PRs that need to be tackled for v0.29 release: v0.30 Issues or PRs that need to be tackled for v0.30 type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants