Fix white bottom on proposal show with voting#14285
Conversation
andreslucena
left a comment
There was a problem hiding this comment.
I can confirm this bug is fixed.
I found another one related to this script: if you change the screen size from sm to xl, the space it still there. This seems a weird scenario but I think it can happen in mobile devices (by changing the orientation from vertical to landscape for instance)
I think it's because we aren't recalculating on resize.
Do you want to do it here or should I create a new issue for that one?
Let's do it here. |
29412fb
andreslucena
left a comment
There was a problem hiding this comment.
Stiill happening even with the resize:
I actually tested on an Ipad, and i have not seen the issue after implementing the resize. I had some Caching issues though ... |
@andreslucena this is ready for another round... |
andreslucena
left a comment
There was a problem hiding this comment.
👏🏽 👏🏽
Now it works just as I'd expect, thanks!
|
Add |
* feature/signature_workflows: Add documentation for signature handler encryption secret and rename environment variable Rename method Fix title on spec for the 'Create new proposal' page (#14347) Fix WCAG search filters navigation (#14014) Fix comment cell to not show reply button when passing MAX_DEPTH (#14291) Fix editing comment with max length setting (#14275) Add title tag on pages for blogs, debates and meetings (#14110) Fix white bottom on proposal show with voting (#14285) New Crowdin updates (#14318) New Crowdin updates (#14217) Fix image missing error (#14175) Add delay of `spam_analysis` queue (#14304) Fix hide comment from interface (#14301) Change "Valuator" for "Evaluator" (#13684) Fix QR code generation (#14300) Patch backporter action (#14292) Change `hide_voting` argument on proposal cell to `show_voting` (#14267)
🎩 What? Why?
Back in #13948, @andreslucena fixed the sticky buttons, on mobile. Unfortunately we have not seen that in the process, we add a white background on proposals show page.
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
Images from: https://nightly.decidim.org/processes/charkarmob/f/5/proposals/8