Skip to content

Add title tag on pages for blogs, debates and meetings#14110

Merged
andreslucena merged 3 commits intodecidim:developfrom
i-need-another-coffee:fix/add-title-to-pages
Mar 18, 2025
Merged

Add title tag on pages for blogs, debates and meetings#14110
andreslucena merged 3 commits intodecidim:developfrom
i-need-another-coffee:fix/add-title-to-pages

Conversation

@andra-panaite
Copy link
Copy Markdown
Contributor

🎩 What? Why?

I have noticed that some pages were missing the correct value for the title tag. Therefore, I have added the title tag on the create page for the following components: Blogs, Debates, and Meetings.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

  1. Go to the Blog/Debate/Meeting index page.
  2. Click the "New" button.
  3. Check the title of the tab.

♥️ Thank you!

github-actions[bot]
github-actions bot previously approved these changes Feb 18, 2025
@alecslupu alecslupu added release: v0.29 Issues or PRs that need to be tackled for v0.29 release: v0.30 Issues or PRs that need to be tackled for v0.30 release: v0.28 Issues or PRs that need to be tackled for v0.28 labels Feb 18, 2025
@greenwoodt greenwoodt self-assigned this Feb 20, 2025
@andreslucena andreslucena changed the title Added title tag on pages Add title tag on pages Feb 21, 2025
@greenwoodt greenwoodt removed their assignment Feb 26, 2025
@alecslupu alecslupu self-assigned this Mar 6, 2025
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a consistency issue but I'll handle in another PR

Thanks for the fix!

@andreslucena andreslucena changed the title Add title tag on pages Add title tag on pages for blogs, debates and meetings Mar 18, 2025
@alecslupu
Copy link
Copy Markdown
Contributor

Found a consistency issue but I'll handle in another PR

What is the consistency issue? My hunch is that we may have an issue on surveys ... but that cannot be sent to 0.23 / 0.29 .

Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's do it here, as I already have the screenshots :)

"New debate" page

"Create new post" page

!["Create Your Meeting" page]https://github.com/user-attachments/assets/1c3f39b5-d34f-4c57-aa1b-dd8a8ff1e992)

"Create your proposal" page

Each page has a different kind of copy and they all should be the same.

Can you change it to

  • Create new debate
  • Create new post
  • Create new meeting
  • Create new proposal

Thanks!

@andra-panaite
Copy link
Copy Markdown
Contributor Author

  • Create new proposal

@andreslucena I have a question regarding the proposal creation form. I noticed that the text from the first step is the same as the form title. Since I will change the form title from 'Create Your Proposal' to 'Create new proposal' should I update the first step text accordingly?

@alecslupu alecslupu requested a review from andreslucena March 18, 2025 12:39
@andreslucena andreslucena merged commit 86eb9a6 into decidim:develop Mar 18, 2025
61 checks passed
@alecslupu alecslupu deleted the fix/add-title-to-pages branch March 18, 2025 14:22
@alecslupu alecslupu removed the release: v0.28 Issues or PRs that need to be tackled for v0.28 label Mar 18, 2025
@alecslupu alecslupu removed the release: v0.29 Issues or PRs that need to be tackled for v0.29 label Mar 18, 2025
entantoencuanto added a commit that referenced this pull request Mar 20, 2025
* feature/signature_workflows:
  Add documentation for signature handler encryption secret and rename environment variable
  Rename method
  Fix title on spec for the 'Create new proposal' page (#14347)
  Fix WCAG search filters navigation (#14014)
  Fix comment cell to not show reply button when passing MAX_DEPTH (#14291)
  Fix editing comment with max length setting (#14275)
  Add title tag on pages for blogs, debates and meetings (#14110)
  Fix white bottom on proposal show with voting (#14285)
  New Crowdin updates (#14318)
  New Crowdin updates (#14217)
  Fix image missing error (#14175)
  Add delay of `spam_analysis` queue (#14304)
  Fix hide comment from interface (#14301)
  Change "Valuator" for "Evaluator" (#13684)
  Fix QR code generation (#14300)
  Patch backporter action (#14292)
  Change `hide_voting` argument on proposal cell to `show_voting` (#14267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: blogs module: debates module: meetings module: proposals release: v0.30 Issues or PRs that need to be tackled for v0.30 type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants