Skip to content

Change "Valuator" for "Evaluator"#13684

Merged
alecslupu merged 80 commits intodecidim:developfrom
greenwoodt:change/valuator-for-evaluator
Mar 17, 2025
Merged

Change "Valuator" for "Evaluator"#13684
alecslupu merged 80 commits intodecidim:developfrom
greenwoodt:change/valuator-for-evaluator

Conversation

@greenwoodt
Copy link
Copy Markdown
Member

@greenwoodt greenwoodt commented Nov 20, 2024

🎩 What? Why?

Terminology updated within the Decidim for the role name of Valuator to Evaluator.

A rake task has also been added to this PR to effect change on a data base level with the addition of decidim-core/lib/tasks/upgrade/decidim_change_valuator_tasks.rake. Meaning the corresponding role: of :valuator can be adapted within the system for example, roles: used in each module and their designated keys within i18n translations.

  • Search and replace each change from "Valuator" to "Evaluator". Keep in mind the 2x 'Ee' in the "Evaluator" change.
  • Run rake task - ./bin/rails decidim:upgrade:decidim_update_valuators. Update FactoryBot role:.
  • Run rake task - ./bin/rails decidim:upgrade:decidim_action_log_valuation_assignment to update the ValuationAssignment in action_log and ./bin/rails decidim:upgrade:decidim_paper_trail_valuation_assignment to update the ValuationAssignment in the paper_trail item_type.
  • File page names adapted from "Valuator" to "Evaluator".
  • Migration of affected columns and tables in the Proposals component.

📌 Related Issues

Testing

  1. Use a Decidim a installation.
  2. Login as a admin
  3. Head over to edit and find the role of Valuator in different modules (for instance Participatory-Processes.
  4. Click a process
  5. Find "Process admins" on the left under Attachments
  6. See the role changed from Valuator changed to Evaluator.

📷 Screenshots

Participatory Processes example:
Screenshot 2024-11-21 at 10 16 23

♥️ Thank you!

github-actions[bot]
github-actions bot previously approved these changes Nov 20, 2024
@greenwoodt greenwoodt changed the title [EPIC] Change "Valuator" for "Evaluator" EPIC -Change "Valuator" for "Evaluator" Nov 20, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 20, 2024
@andreslucena andreslucena changed the title EPIC -Change "Valuator" for "Evaluator" Change "Valuator" for "Evaluator" Nov 20, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 20, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 21, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 21, 2024
@andreslucena
Copy link
Copy Markdown
Member

@greenwoodt please let's check this out whenever we both are in the office. We have hundreds of files to change and we need to automate this change.

github-actions[bot]
github-actions bot previously approved these changes Mar 3, 2025
github-actions[bot]
github-actions bot previously approved these changes Mar 5, 2025
github-actions[bot]
github-actions bot previously approved these changes Mar 5, 2025
@andreslucena
Copy link
Copy Markdown
Member

@greenwoodt can you solve the conflicts?
For me it'd be ready to merge after we solve that.
I'll pass the ball to @alecslupu just in case

github-actions[bot]
github-actions bot previously approved these changes Mar 7, 2025
github-actions[bot]
github-actions bot previously approved these changes Mar 7, 2025
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes Mar 7, 2025
@greenwoodt
Copy link
Copy Markdown
Member Author

@greenwoodt can you solve the conflicts? For me it'd be ready to merge after we solve that. I'll pass the ball to @alecslupu just in case

All done!

andreslucena
andreslucena previously approved these changes Mar 7, 2025
@andreslucena
Copy link
Copy Markdown
Member

@alecslupu can you check this one out 🙏🏽 ? Thanks!

github-actions[bot]
github-actions bot previously approved these changes Mar 13, 2025
@alecslupu
Copy link
Copy Markdown
Contributor

@greenwoodt Could you fix the conflicts ?

@greenwoodt
Copy link
Copy Markdown
Member Author

@greenwoodt Could you fix the conflicts ?

Done

github-actions[bot]
github-actions bot previously approved these changes Mar 14, 2025
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

106/106

Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[EPIC] Change "valuator" for "evaluator"

3 participants