Skip to content

Change hide_voting argument on proposal cell to show_voting#14267

Merged
andreslucena merged 3 commits intodevelopfrom
fix/proposal/parameter-change
Mar 14, 2025
Merged

Change hide_voting argument on proposal cell to show_voting#14267
andreslucena merged 3 commits intodevelopfrom
fix/proposal/parameter-change

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Mar 10, 2025

🎩 What? Why?

Back in #14244 @andreslucena left a comment suggesting to change the case when we are using / hiding the votes actions. This is a PR adding just that.

📌 Related Issues

Link your PR to an issue

Testing

  1. Pipeline should be green

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

github-actions[bot]
github-actions bot previously approved these changes Mar 10, 2025
@alecslupu alecslupu changed the title Fix - rename hide_voting to show_voting Fix: rename hide_voting to show_voting Mar 10, 2025
@alecslupu alecslupu changed the title Fix: rename hide_voting to show_voting Rename hide_voting to show_voting Mar 10, 2025
@alecslupu alecslupu added the release: v0.30 Issues or PRs that need to be tackled for v0.30 label Mar 10, 2025
@alecslupu alecslupu marked this pull request as ready for review March 11, 2025 06:37
@alecslupu alecslupu requested a review from andreslucena March 11, 2025 06:37
@andreslucena andreslucena changed the title Rename hide_voting to show_voting Change hide_voting argument on proposal cell to show_voting Mar 12, 2025
@alecslupu alecslupu moved this to 👀 In review in Maintainers' backlog Mar 13, 2025
@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Mar 13, 2025

Related to #13883, #14244, #14087 and #14035

Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a bit of research and as far as I understand, this would have prevented #14244, #14087 and #14035.

LGTM!

@andreslucena andreslucena merged commit b005a7d into develop Mar 14, 2025
127 checks passed
@andreslucena andreslucena deleted the fix/proposal/parameter-change branch March 14, 2025 13:20
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Maintainers' backlog Mar 14, 2025
@alecslupu alecslupu added the no-backport Pull Requests that should not be backported label Mar 18, 2025
@alecslupu
Copy link
Copy Markdown
Contributor Author

Add no-backport, as the feature does not exist in 0.29

entantoencuanto added a commit that referenced this pull request Mar 20, 2025
* feature/signature_workflows:
  Add documentation for signature handler encryption secret and rename environment variable
  Rename method
  Fix title on spec for the 'Create new proposal' page (#14347)
  Fix WCAG search filters navigation (#14014)
  Fix comment cell to not show reply button when passing MAX_DEPTH (#14291)
  Fix editing comment with max length setting (#14275)
  Add title tag on pages for blogs, debates and meetings (#14110)
  Fix white bottom on proposal show with voting (#14285)
  New Crowdin updates (#14318)
  New Crowdin updates (#14217)
  Fix image missing error (#14175)
  Add delay of `spam_analysis` queue (#14304)
  Fix hide comment from interface (#14301)
  Change "Valuator" for "Evaluator" (#13684)
  Fix QR code generation (#14300)
  Patch backporter action (#14292)
  Change `hide_voting` argument on proposal cell to `show_voting` (#14267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core module: proposals module: sortitions no-backport Pull Requests that should not be backported release: v0.30 Issues or PRs that need to be tackled for v0.30 type: fix PRs that implement a fix for a bug

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants