Skip to content

Fix QR code generation#14300

Merged
andreslucena merged 7 commits intodevelopfrom
fix/qr-code
Mar 17, 2025
Merged

Fix QR code generation#14300
andreslucena merged 7 commits intodevelopfrom
fix/qr-code

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

While validating the ticket on our end, our tester noticed the QR code from the download page, is broken.
On a deeper investigation, i have noticed the shortlink is different, due to fact that the new controller did not had available the component, and participatory process slug.

This PR fixes that.

📌 Related Issues

Link your PR to an issue

Testing

  1. Visit a proposal, click share, the QR
  2. Scan with a phone, and see the destination url
  3. Click Download, then repeat step 2
  4. See the page has error.
  5. Apply patch
  6. Repeat step 2 + step 3
  7. See there is no error
    ♥️ Thank you!

@alecslupu alecslupu added type: fix PRs that implement a fix for a bug release: v0.30 Issues or PRs that need to be tackled for v0.30 labels Mar 13, 2025
github-actions[bot]
github-actions bot previously approved these changes Mar 13, 2025
@andreslucena andreslucena merged commit d022e71 into develop Mar 17, 2025
118 checks passed
@andreslucena andreslucena deleted the fix/qr-code branch March 17, 2025 08:56
@alecslupu alecslupu added no-backport Pull Requests that should not be backported and removed release: v0.30 Issues or PRs that need to be tackled for v0.30 labels Mar 17, 2025
entantoencuanto added a commit that referenced this pull request Mar 20, 2025
* feature/signature_workflows:
  Add documentation for signature handler encryption secret and rename environment variable
  Rename method
  Fix title on spec for the 'Create new proposal' page (#14347)
  Fix WCAG search filters navigation (#14014)
  Fix comment cell to not show reply button when passing MAX_DEPTH (#14291)
  Fix editing comment with max length setting (#14275)
  Add title tag on pages for blogs, debates and meetings (#14110)
  Fix white bottom on proposal show with voting (#14285)
  New Crowdin updates (#14318)
  New Crowdin updates (#14217)
  Fix image missing error (#14175)
  Add delay of `spam_analysis` queue (#14304)
  Fix hide comment from interface (#14301)
  Change "Valuator" for "Evaluator" (#13684)
  Fix QR code generation (#14300)
  Patch backporter action (#14292)
  Change `hide_voting` argument on proposal cell to `show_voting` (#14267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core module: initiatives no-backport Pull Requests that should not be backported type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants