Add QR code for share modal by alecslupu · Pull Request #14086 · decidim/decidim

alecslupu · 2025-02-14T19:36:44Z

🎩 What? Why?

This PR adds a new social Share service, that allows you to display any QR codes for your resources.

📌 Related Issues

Link your PR to an issue

Related to #?
Fixes Share via QR Code #14020

Testing

Create a new development app, or change your social_share_services yaml key to include QR ( check RELEASE_NOTES )
Restart the application
Visit any meeting, proposal, project, debate page and click Share
See that you have a new layout
See that you have a new QR icon
Click on QR, see functionality
Additionally, when checking modal check for resources having image attachments or not (to see how the card or placeholder is displayed )

📷 Screenshots

Please add screenshots of the changes you are proposing

♥️ Thank you!

decidim-core/app/cells/decidim/share_widget_cell.rb

decidim-core/decidim-core.gemspec

alecslupu · 2025-03-04T13:34:21Z

@andreslucena this is ready for another round

decidim-core/app/helpers/decidim/qr_code_helper.rb

decidim-core/lib/decidim/core.rb

decidim-core/lib/decidim/core/engine.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

Already made the review

* develop: Fix user activity filter (#14170) Add QR code for share modal (#14086) Update node version from v18 to v22 (#14224)

alecslupu added 3 commits February 14, 2025 21:34

Add QR library

ef20777

Add QR button

eca5ef0

Temporary commit

9e3c0e0

alecslupu added the type: feature label Feb 14, 2025

github-actions bot added module: core dependencies Pull requests that update a dependency file or issues that talk about updating dependencies module: generators labels Feb 14, 2025

github-advanced-security bot found potential problems Feb 14, 2025

View reviewed changes

decidim-core/app/cells/decidim/share_widget_cell.rb Fixed Show fixed Hide fixed

decidim-core/app/cells/decidim/share_widget_cell.rb Fixed Show fixed Hide fixed

decidim-core/decidim-core.gemspec Fixed Show fixed Hide fixed

github-actions bot previously approved these changes Feb 14, 2025

View reviewed changes

alecslupu added 2 commits February 14, 2025 22:36

Running linters

97fa90f

Refactor the share modal

b89498e

alecslupu dismissed github-actions[bot]’s stale review via b89498e February 15, 2025 18:57

github-actions bot added the configuration label Feb 15, 2025

github-actions bot previously approved these changes Feb 15, 2025

View reviewed changes

Customise the qr pop-up

4135673

alecslupu dismissed github-actions[bot]’s stale review via 4135673 February 16, 2025 01:13

github-actions bot added module: proposals module: meetings module: budgets module: debates module: blogs module: dev module: sortitions module: initiatives module: design labels Feb 16, 2025

github-actions bot previously approved these changes Feb 16, 2025

View reviewed changes

Fix errors

5384ec2

alecslupu dismissed github-actions[bot]’s stale review via 5384ec2 February 16, 2025 02:09

github-actions bot previously approved these changes Feb 16, 2025

View reviewed changes

Refactor on share-modal

1e020fb

alecslupu dismissed github-actions[bot]’s stale review via ec562c2 March 4, 2025 11:44

github-actions bot previously approved these changes Mar 4, 2025

View reviewed changes

Running css linters

aa089e3

alecslupu dismissed github-actions[bot]’s stale review via aa089e3 March 4, 2025 11:50

github-actions bot previously approved these changes Mar 4, 2025

View reviewed changes

alecslupu requested a review from andreslucena March 4, 2025 13:34

andreslucena requested changes Mar 5, 2025

View reviewed changes

decidim-core/app/helpers/decidim/qr_code_helper.rb Outdated Show resolved Hide resolved

decidim-core/lib/decidim/core.rb Outdated Show resolved Hide resolved

andreslucena reviewed Mar 5, 2025

View reviewed changes

decidim-core/lib/decidim/core/engine.rb Show resolved Hide resolved

Update the docs

def6b6e

alecslupu dismissed github-actions[bot]’s stale review via def6b6e March 5, 2025 11:25

github-actions bot added the team: documentation label Mar 5, 2025

github-actions bot previously approved these changes Mar 5, 2025

View reviewed changes

Add budgets exception

4a847c8

alecslupu dismissed github-actions[bot]’s stale review via 4a847c8 March 5, 2025 11:26

github-actions bot previously approved these changes Mar 5, 2025

View reviewed changes

Update decidim-core/lib/decidim/core.rb

b2d97d2

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

alecslupu dismissed github-actions[bot]’s stale review via b2d97d2 March 5, 2025 11:47

github-actions bot approved these changes Mar 5, 2025

View reviewed changes

andreslucena approved these changes Mar 5, 2025

View reviewed changes

andreslucena changed the title ~~Add QR library~~ Add QR code for share modal Mar 5, 2025

andreslucena merged commit 607f260 into develop Mar 5, 2025
121 checks passed

andreslucena deleted the feature/add-qr-code branch March 5, 2025 12:58

github-project-automation bot moved this from 👀 In review to ✅ Done in Maintainers' backlog Mar 5, 2025

entantoencuanto added a commit that referenced this pull request Mar 5, 2025

Merge branch 'develop' into staging-lot2

26e6440

* develop: Fix user activity filter (#14170) Add QR code for share modal (#14086) Update node version from v18 to v22 (#14224)

alecslupu mentioned this pull request Mar 13, 2025

Fix QR code generation #14300

Merged

andreslucena mentioned this pull request Apr 30, 2025

Add missing i18n strings from ca/es AjuntamentdeBarcelona/decidim#49

Merged

alecslupu added this to the 0.31.0 milestone Nov 20, 2025

alecslupu added the type: feature label Feb 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add QR code for share modal#14086

Add QR code for share modal#14086
andreslucena merged 46 commits intodevelopfrom
feature/add-qr-code

alecslupu commented Feb 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alecslupu commented Mar 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

alecslupu commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

Testing

📷 Screenshots

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alecslupu commented Mar 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alecslupu commented Feb 14, 2025 •

edited

Loading