Skip to content

Fix user activity filter#14170

Merged
andreslucena merged 5 commits intodevelopfrom
fix/user-activity-filter
Mar 5, 2025
Merged

Fix user activity filter#14170
andreslucena merged 5 commits intodevelopfrom
fix/user-activity-filter

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Feb 26, 2025

🎩 What? Why?

While visiting the user profile to select various actions, i have noticed that the filter is not properly working. This PR fixes the issue.

📌 Related Issues

Link your PR to an issue

Testing

  1. Go to a user profile page ( ex user@example.org)
  2. See the filters in left
  3. Click on comments
  4. See that you are in the last activity page
  5. Apply patch
  6. Go to a user profile page ( ex user@example.org)
  7. See the filters in left
  8. Click on comments
  9. See that only comments of the visited users are being displayed

♥️ Thank you!

@github-actions github-actions bot added module: core type: fix PRs that implement a fix for a bug labels Feb 26, 2025
github-actions[bot]
github-actions bot previously approved these changes Feb 26, 2025
View reviewed changes
@alecslupu alecslupu added release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 release: v0.30 Issues or PRs that need to be tackled for v0.30 labels Feb 26, 2025
github-actions[bot]
github-actions bot previously approved these changes Feb 26, 2025
View reviewed changes
@alecslupu alecslupu marked this pull request as ready for review February 27, 2025 02:55
@alecslupu alecslupu moved this to 👀 In review in Maintainers' backlog Feb 27, 2025
andreslucena
andreslucena reviewed Mar 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on my machine :)

Can you add some system specs that would have detected this bug? Thanks

andreslucena
andreslucena requested changes Mar 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment #14170 (review)

@alecslupu
Copy link
Copy Markdown
Contributor Author

alecslupu commented Mar 5, 2025

It works on my machine

image

github-actions[bot]
github-actions bot previously approved these changes Mar 5, 2025
View reviewed changes
@andreslucena
Copy link
Copy Markdown
Member

andreslucena commented Mar 5, 2025

image

andreslucena
andreslucena requested changes Mar 5, 2025
View reviewed changes
@andreslucena andreslucena merged commit b5f8bda into develop Mar 5, 2025
118 checks passed
@andreslucena andreslucena deleted the fix/user-activity-filter branch March 5, 2025 14:20
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Maintainers' backlog Mar 5, 2025
This was referenced Mar 5, 2025
Merged
Merged
Merged
entantoencuanto added a commit that referenced this pull request Mar 5, 2025
@entantoencuanto
Merge branch 'develop' into staging-lot2
26e6440 
* develop:
  Fix user activity filter (#14170)
  Add QR code for share modal (#14086)
  Update node version from v18 to v22 (#14224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@andreslucena andreslucena

Labels

module: core release: v0.28 Issues or PRs that need to be tackled for v0.28 release: v0.29 Issues or PRs that need to be tackled for v0.29 release: v0.30 Issues or PRs that need to be tackled for v0.30 type: fix PRs that implement a fix for a bug

Projects

No open projects
Maintainers' backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

User's Activity filter redirects in last_activity page

2 participants

@alecslupu @andreslucena