Skip to content

Fix hide comment from interface#14301

Merged
andreslucena merged 3 commits intodevelopfrom
fix/hide-comments
Mar 17, 2025
Merged

Fix hide comment from interface#14301
andreslucena merged 3 commits intodevelopfrom
fix/hide-comments

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

While investigating #13087, @robertluca-publicis found out that in some cases, the nested comments of a resource hidden are not actually processed when the spam user does not exist. This PR fixes the issue.

📌 Related Issues

Link your PR to an issue

Testing

  1. Make sure you do not have the spam user installed
  2. Logged in as admin visit a propoal with comments
  3. Find a comment with answers and report / hide it
  4. See the number of comments is not updated properly (ex: proposal idicates it has 10 comments, but visible are only 6)
  5. Apply patch
  6. Repeat steps 2 and 3
  7. See the number of comments

♥️ Thank you!

@alecslupu alecslupu added the release: v0.30 Issues or PRs that need to be tackled for v0.30 label Mar 14, 2025
@github-actions github-actions bot added module: core type: fix PRs that implement a fix for a bug labels Mar 14, 2025
github-actions[bot]
github-actions bot previously approved these changes Mar 14, 2025
@andreslucena
Copy link
Copy Markdown
Member

Oh I see, it was raising an exception because the user wasn't found, right?

Can you add some specs to this with the different cases (user exists and user doesn't exists) 🙏🏽 ?

Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment: #14301 (comment)

@alecslupu
Copy link
Copy Markdown
Contributor Author

Can you add some specs to this with the different cases (user exists and user doesn't exists) 🙏🏽 ?

done in fa12c22

@alecslupu alecslupu requested a review from andreslucena March 15, 2025 19:23
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful-rumi-robinson

@andreslucena andreslucena merged commit a1e1703 into develop Mar 17, 2025
118 checks passed
@andreslucena andreslucena deleted the fix/hide-comments branch March 17, 2025 09:48
@alecslupu alecslupu added the release: v0.29 Issues or PRs that need to be tackled for v0.29 label Mar 18, 2025
entantoencuanto added a commit that referenced this pull request Mar 20, 2025
* feature/signature_workflows:
  Add documentation for signature handler encryption secret and rename environment variable
  Rename method
  Fix title on spec for the 'Create new proposal' page (#14347)
  Fix WCAG search filters navigation (#14014)
  Fix comment cell to not show reply button when passing MAX_DEPTH (#14291)
  Fix editing comment with max length setting (#14275)
  Add title tag on pages for blogs, debates and meetings (#14110)
  Fix white bottom on proposal show with voting (#14285)
  New Crowdin updates (#14318)
  New Crowdin updates (#14217)
  Fix image missing error (#14175)
  Add delay of `spam_analysis` queue (#14304)
  Fix hide comment from interface (#14301)
  Change "Valuator" for "Evaluator" (#13684)
  Fix QR code generation (#14300)
  Patch backporter action (#14292)
  Change `hide_voting` argument on proposal cell to `show_voting` (#14267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core release: v0.29 Issues or PRs that need to be tackled for v0.29 release: v0.30 Issues or PRs that need to be tackled for v0.30 type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replies of the moderated comments are counted even if are hidden on both general search and resource page

2 participants