Fix comment cell to not show reply button when passing MAX_DEPTH#14291
Merged
andreslucena merged 4 commits intodecidim:developfrom Mar 18, 2025
Merged
Conversation
…n_max_depth_comment
alecslupu
previously approved these changes
Mar 13, 2025
Contributor
There was a problem hiding this comment.
👍
I could replicate the behavior on Nightly, but i could not replicate it on my local. Maybe @greenwoodt has more success.
679bd81
andreslucena
approved these changes
Mar 18, 2025
Member
andreslucena
left a comment
There was a problem hiding this comment.
Great job here too @robertluca-publicis!!
entantoencuanto
added a commit
that referenced
this pull request
Mar 20, 2025
* feature/signature_workflows: Add documentation for signature handler encryption secret and rename environment variable Rename method Fix title on spec for the 'Create new proposal' page (#14347) Fix WCAG search filters navigation (#14014) Fix comment cell to not show reply button when passing MAX_DEPTH (#14291) Fix editing comment with max length setting (#14275) Add title tag on pages for blogs, debates and meetings (#14110) Fix white bottom on proposal show with voting (#14285) New Crowdin updates (#14318) New Crowdin updates (#14217) Fix image missing error (#14175) Add delay of `spam_analysis` queue (#14304) Fix hide comment from interface (#14301) Change "Valuator" for "Evaluator" (#13684) Fix QR code generation (#14300) Patch backporter action (#14292) Change `hide_voting` argument on proposal cell to `show_voting` (#14267)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Reply button is available on comments at MAX_DEPTH and the reply will fail because of the depth validation on the comment model.
📌 Related Issues
Testing