Vote on proposal from listing page#13883
Merged
andreslucena merged 38 commits intodecidim:developfrom Feb 6, 2025
Merged
Conversation
carolromero
requested changes
Jan 23, 2025
Member
There was a problem hiding this comment.
@alecslupu I finished reviewing this, and have tried to be as systematic as possible so as not to miss any details or variations. I think with these changes it will be ready but if in doubt in the figma are all the elements:
General
- 'Already voted' missing 'check' icon (see Figma)
- With supports enabled and blocked, the button should be displayed as disabled (see Figma)
- Design breaks when clicking on button
- In Show pages appear two CTAs
Both desktop and mobile | votes enabled / with or without threshold
Card view
- Change button width (W164)
- Change grey area height (H68)
- Align votes counter
List view
- Change button width (W164)
- Change grey area height (H68)
- Change grey area width (W196)
andreslucena
reviewed
Feb 4, 2025
decidim-proposals/app/views/decidim/proposals/proposal_votes/update_buttons_and_counters.js.erb
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@andreslucena , this is ready for another round. |
antopalidi
pushed a commit
to openpoke/decidim
that referenced
this pull request
Feb 12, 2025
* Added vote on proposals listing page * Run linter * Fixed tests * Run linter * Refactor for proposal cards vote button * Changed markup * Updated test file to current markup * add styling for listing and grid view * Added class on progress-bar container * styling for grid and listing with and without progress bar * code refactor and small styling fixes * change layout for votes on proposals with votes limit * Added class when votes counter is hidden * design changes for votes hidden * css fixes * Run linter * Fixed test * Refactoring code * Run prettier * changes after review * Final fixes * Fix proposals * Fix failing specs * Add specs * Finish specs * Refactor css * Refactor js selector * Run linters * Refactor remaining votes counter to data attribute --------- Co-authored-by: andra-panaite <andra.panaite@tremend.com> Co-authored-by: MariaDascaluPublicis <maria.dascalu@publicissapient.com>
mllocs
pushed a commit
that referenced
this pull request
Feb 13, 2025
* Added vote on proposals listing page * Run linter * Fixed tests * Run linter * Refactor for proposal cards vote button * Changed markup * Updated test file to current markup * add styling for listing and grid view * Added class on progress-bar container * styling for grid and listing with and without progress bar * code refactor and small styling fixes * change layout for votes on proposals with votes limit * Added class when votes counter is hidden * design changes for votes hidden * css fixes * Run linter * Fixed test * Refactoring code * Run prettier * changes after review * Final fixes * Fix proposals * Fix failing specs * Add specs * Finish specs * Refactor css * Refactor js selector * Run linters * Refactor remaining votes counter to data attribute --------- Co-authored-by: andra-panaite <andra.panaite@tremend.com> Co-authored-by: MariaDascaluPublicis <maria.dascalu@publicissapient.com>
andreslucena
pushed a commit
that referenced
this pull request
Mar 3, 2025
* Added vote on proposals listing page * Run linter * Fixed tests * Run linter * Refactor for proposal cards vote button * Changed markup * Updated test file to current markup * add styling for listing and grid view * Added class on progress-bar container * styling for grid and listing with and without progress bar * code refactor and small styling fixes * change layout for votes on proposals with votes limit * Added class when votes counter is hidden * design changes for votes hidden * css fixes * Run linter * Fixed test * Refactoring code * Run prettier * changes after review * Final fixes * Fix proposals * Fix failing specs * Add specs * Finish specs * Refactor css * Refactor js selector * Run linters * Refactor remaining votes counter to data attribute --------- Co-authored-by: andra-panaite <andra.panaite@tremend.com> Co-authored-by: MariaDascaluPublicis <maria.dascalu@publicissapient.com>
alecslupu
added a commit
to i-need-another-coffee/decidim
that referenced
this pull request
Mar 6, 2025
* Added vote on proposals listing page * Run linter * Fixed tests * Run linter * Refactor for proposal cards vote button * Changed markup * Updated test file to current markup * add styling for listing and grid view * Added class on progress-bar container * styling for grid and listing with and without progress bar * code refactor and small styling fixes * change layout for votes on proposals with votes limit * Added class when votes counter is hidden * design changes for votes hidden * css fixes * Run linter * Fixed test * Refactoring code * Run prettier * changes after review * Final fixes * Fix proposals * Fix failing specs * Add specs * Finish specs * Refactor css * Refactor js selector * Run linters * Refactor remaining votes counter to data attribute --------- Co-authored-by: andra-panaite <andra.panaite@tremend.com> Co-authored-by: MariaDascaluPublicis <maria.dascalu@publicissapient.com>
Contributor
|
@alecslupu @andreslucena I think this PR introduced a bug. The proposal cell is used in a meeting page when a meeting has linked proposals. It throws an exception because it is trying to access |
Contributor
Author
Can you gimme a stacktrace, or add a |
Merged
Contributor
Author
I have added the fix on #14244 |
fblupi
pushed a commit
to AjuntamentdeBarcelona/decidim
that referenced
this pull request
Mar 31, 2025
* Added vote on proposals listing page * Run linter * Fixed tests * Run linter * Refactor for proposal cards vote button * Changed markup * Updated test file to current markup * add styling for listing and grid view * Added class on progress-bar container * styling for grid and listing with and without progress bar * code refactor and small styling fixes * change layout for votes on proposals with votes limit * Added class when votes counter is hidden * design changes for votes hidden * css fixes * Run linter * Fixed test * Refactoring code * Run prettier * changes after review * Final fixes * Fix proposals * Fix failing specs * Add specs * Finish specs * Refactor css * Refactor js selector * Run linters * Refactor remaining votes counter to data attribute --------- Co-authored-by: andra-panaite <andra.panaite@tremend.com> Co-authored-by: MariaDascaluPublicis <maria.dascalu@publicissapient.com>
microstudi
pushed a commit
to openpoke/decidim
that referenced
this pull request
Mar 10, 2026
* Added vote on proposals listing page * Run linter * Fixed tests * Run linter * Refactor for proposal cards vote button * Changed markup * Updated test file to current markup * add styling for listing and grid view * Added class on progress-bar container * styling for grid and listing with and without progress bar * code refactor and small styling fixes * change layout for votes on proposals with votes limit * Added class when votes counter is hidden * design changes for votes hidden * css fixes * Run linter * Fixed test * Refactoring code * Run prettier * changes after review * Final fixes * Fix proposals * Fix failing specs * Add specs * Finish specs * Refactor css * Refactor js selector * Run linters * Refactor remaining votes counter to data attribute --------- Co-authored-by: andra-panaite <andra.panaite@tremend.com> Co-authored-by: MariaDascaluPublicis <maria.dascalu@publicissapient.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR reintroduces the functionality of voting a proposal directly from index page.
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
Please add screenshots of the changes you are proposing
