Conversation
andreslucena
left a comment
There was a problem hiding this comment.
Seems like we're playing wack-a-mole with this bug.
I think we should re-think the hide_voting argument, so it is actually a show_voting that's only called when we actually have a voting with a proposal card (basically in the proposal index page, if I'm not mistaken).
If you want, we can merge this as is (as it is fixing this particular issue), but what I'd want is to have another PR afterwards with a rethink of this feature, as I think there are too many places where this card is used (for instance sortitions, where we had this same bug with #14087)
|
Merging as this is fixing the issue (and hopefully we can fix the real problem as I'm proposing in my comment in the next few weeks 😄) |
|
adding |
* Fix linked proposals * Add specs
🎩 What? Why?
Today @mllocs let me know that linked proposals to meetings are actually raising an error. This is the same error i got while trying to implement the proposal voting in the 0.29 branch.
This was not caught before because it was not added in the meetings, and in the budgets (where i've encountered the issue) we have the history implementation.
📌 Related Issues
Link your PR to an issue
Testing