Skip to content

Fix display proposals in sortitions when votes enabled#14087

Merged
andreslucena merged 1 commit intodevelopfrom
fix/sortitions
Feb 19, 2025
Merged

Fix display proposals in sortitions when votes enabled#14087
andreslucena merged 1 commit intodevelopfrom
fix/sortitions

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Feb 16, 2025

🎩 What? Why?

While working on the QR implementation (#14086), i have noticed the survey proposals page is raising an error.

📌 Related Issues

Link your PR to an issue

Testing

  1. Visit a proposal component admin panel
  2. Enable voting for the respective component
  3. Visit the sortition component & create a sortition
  4. Visit public sortition page
  5. See the error
  6. Apply patch
  7. Refresh
  8. See the error is gone

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@alecslupu alecslupu added type: fix PRs that implement a fix for a bug no-backport Pull Requests that should not be backported labels Feb 16, 2025
@greenwoodt greenwoodt self-requested a review February 18, 2025 08:13
@greenwoodt greenwoodt self-assigned this Feb 18, 2025
greenwoodt
greenwoodt approved these changes Feb 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@greenwoodt greenwoodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected with spec!

@alecslupu alecslupu added the release: v0.30 Issues or PRs that need to be tackled for v0.30 label Feb 18, 2025
andreslucena
andreslucena approved these changes Feb 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm-3

@andreslucena andreslucena merged commit d0148e7 into develop Feb 19, 2025
@andreslucena andreslucena deleted the fix/sortitions branch February 19, 2025 10:22
@alecslupu alecslupu removed the no-backport Pull Requests that should not be backported label Feb 19, 2025
@alecslupu alecslupu mentioned this pull request Feb 19, 2025
Merged
@alecslupu alecslupu added the no-backport Pull Requests that should not be backported label Feb 19, 2025
andreslucena pushed a commit that referenced this pull request Mar 3, 2025
@alecslupu @andreslucena
Fix display proposals in sortitions when votes enabled (#14087)
506e40e
alecslupu added a commit to i-need-another-coffee/decidim that referenced this pull request Mar 6, 2025
@alecslupu
Fix display proposals in sortitions when votes enabled (decidim#14087)
92b0aa2
@alecslupu alecslupu mentioned this pull request Mar 6, 2025
Closed
This was referenced Mar 9, 2025
Merged
Merged
fblupi pushed a commit to AjuntamentdeBarcelona/decidim that referenced this pull request Mar 31, 2025
@alecslupu @fblupi
Fix display proposals in sortitions when votes enabled (decidim#14087)
dd5e573
@fblupi fblupi mentioned this pull request Mar 31, 2025
Merged
@fblupi fblupi mentioned this pull request Apr 10, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@greenwoodt greenwoodt greenwoodt approved these changes

Assignees

@andreslucena andreslucena

@greenwoodt greenwoodt

Labels

module: sortitions no-backport Pull Requests that should not be backported release: v0.30 Issues or PRs that need to be tackled for v0.30 type: fix PRs that implement a fix for a bug

Projects

No open projects
Maintainers' backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alecslupu @andreslucena @greenwoodt