Fix proposal listing on space's index content block#14035
Merged
andreslucena merged 6 commits intodevelopfrom Feb 11, 2025
Merged
Fix proposal listing on space's index content block#14035andreslucena merged 6 commits intodevelopfrom
andreslucena merged 6 commits intodevelopfrom
Conversation
andreslucena
requested changes
Feb 10, 2025
Member
andreslucena
left a comment
There was a problem hiding this comment.
I see that this is indeed fixing the issue, but instead of the issue that you've found, I'm also seeing a 500 error in develop related to this content block:
ActionView::Template::Error (undefined local variable or method `current_settings' for an instance of Decidim::Proposals::ProposalLCell):
32: <% active_content_blocks.each do |content_block| %>
33: <% next unless content_block.manifest %>
34:
35: <%= cell content_block.manifest.cell, content_block %>
36: <% end %>
37:
38: </div>
activesupport (7.0.8.4) lib/active_support/core_ext/module/delegation.rb:307:in `method_missing'
/home/apereira/Work/decidim/decidim/decidim-proposals/app/cells/decidim/proposals/proposal_l/show.erb:8:in `__tilt_60240'
tilt (2.6.0) lib/tilt/template.rb:394:in `bind_call'
This is actually fixed with your PR, but can you do a spec for this case? Ideally this should be in decidim-proposals/spec/cells/decidim/proposals/highlighted_proposals_for_component_cell_spec.rb (but if you can't reproduce it there then I guess we can do a system spec)
Contributor
Author
This is exactly the issue i have found while trying to develop. Later on, i realized that anything else of the exception, is just a proposal cell cache. |
decidim-proposals/spec/cells/decidim/proposals/highlighted_proposals_for_component_cell_spec.rb
Fixed
Show fixed
Hide fixed
Contributor
Author
|
@andreslucena this should be ready for another round. |
andreslucena
approved these changes
Feb 11, 2025
antopalidi
pushed a commit
to openpoke/decidim
that referenced
this pull request
Feb 12, 2025
* Fix proposal listing on Process Space Page * Add cache key to show/hide voting * Add specs * Fix Spelling
mllocs
pushed a commit
that referenced
this pull request
Feb 13, 2025
* Fix proposal listing on Process Space Page * Add cache key to show/hide voting * Add specs * Fix Spelling
andreslucena
pushed a commit
that referenced
this pull request
Mar 3, 2025
* Fix proposal listing on Process Space Page * Add cache key to show/hide voting * Add specs * Fix Spelling
alecslupu
added a commit
to i-need-another-coffee/decidim
that referenced
this pull request
Mar 6, 2025
* Fix proposal listing on Process Space Page * Add cache key to show/hide voting * Add specs * Fix Spelling
fblupi
pushed a commit
to AjuntamentdeBarcelona/decidim
that referenced
this pull request
Mar 31, 2025
* Fix proposal listing on Process Space Page * Add cache key to show/hide voting * Add specs * Fix Spelling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While trying to review #14030, i have noticed that on nightly, we get the following layout:
This PR hides the voting component in the highlighted proposals cell to respect the previous layout.
While trying on my local, i have noticed that the page is raising an error
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
Please add screenshots of the changes you are proposing
