Migrate Survey export to use HexaPDF#13617
Merged
andreslucena merged 13 commits intodevelopfrom Nov 15, 2024
Merged
Conversation
eeeb5fe to
34efd20
Compare
andreslucena
requested changes
Nov 14, 2024
Member
andreslucena
left a comment
There was a problem hiding this comment.
I tried it out and it worked as expected, congratulations!
For documentation purposes, this is what it looks like before and with this PR:
hexa-survey_user_answers-2024-11-14-60548.pdf
wkhtmltopdf-survey_user_answers-2024-11-14-57717.pdf
Apart from the things that I'm mentioning, can you merge with latest develop? There's a bug with the "Download your data" page that we need to fix too (missing i18n key).
decidim-forms/app/packs/entrypoints/decidim_questionnaire_answers_pdf.scss
Show resolved
Hide resolved
Member
|
There are two details that we need to fix IMO:
|
andreslucena
requested changes
Nov 15, 2024
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
|
Will be backported to 0.28 version this fix? @andreslucena @alecslupu Tx! |
Member
|
@aramollis no, this is a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR aims to change the syntax of the survey PDF export to use the hexaPDF library, so that we can deprecate and remove wicked_pdf.
📌 Related Issues
Link your PR to an issue
wicked_pdf_stylesheet_pack_tagwhen exporting questionnaire/survey answers as PDF #12135Testing
wkhtmltopdf-survey.pdf
hexapdf-survey.pdf
📷 Screenshots
Please add screenshots of the changes you are proposing
