Remove wkhtmltopdf-binary gem and wicked configuration#13616
Merged
Remove wkhtmltopdf-binary gem and wicked configuration#13616
Conversation
alecslupu
approved these changes
Nov 7, 2024
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
I would have removed the initializers, but since we plan to have them replaced with HexaPDF, i’ll let it slide.
This was referenced Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
As mentioned in #13553, we're having problems with latest versions of
wkhtmltopdf-binary. Aswkhtmltopdfitself doesn't have any maintenance, we'll migrate from it in another PR.This PR removes the
wkhtmltopdf-binaryfrom our dependencies, as the current version that we have (0.12.6.6) is not compatible with latest Ubuntu LTS (24.04). We can't update to latest version as there are too many binaries and make the gem size too big for certain environments (such as Heroku).As mentioned, we're planning to drop the
wkhtmltopdfdependency, but that will not be backported (as it'll be atype: change).📌 Related Issues
Testing
wkhtmltopdfpackage from your distribution📷 Screenshots