Use the component name in the sidebar title#11088
Merged
ferblape merged 4 commits intofeature/redesignfrom Jun 23, 2023
Merged
Conversation
furilo
approved these changes
Jun 23, 2023
fblupi
requested changes
Jun 23, 2023
Member
fblupi
left a comment
There was a problem hiding this comment.
Looks good but could you include some specs to test it?
Contributor
Author
|
Done @fblupi. Tried a shared example but sometimes in the tests I need to visit the component page and other times it's already there. Anyway it's not a big deal IMHO, the duplication is minor. |
Member
Some of the tests are failing, once the pipeline is green, I'll approve the PR. Code-wisely it looks good to me. |
Contributor
Author
|
Tests fixed @fblupi. I've also fixed the code in conferences, since it's a participatory space and not a component the change didn't make any sense (children components do use the title properly). |
fblupi
approved these changes
Jun 23, 2023
entantoencuanto
added a commit
that referenced
this pull request
Jun 23, 2023
* feature/redesign: (26 commits) Use the component name in the sidebar title (#11088) Redesign: layout center (#11068) Redesign: display only public users followings in following profile tab (#11051) Redesign: fix cards (#11072) Redesign: remove gcalendar warning (#10999) lock sass-embedded (#11077) Redesign: scopes picker (#11039) Redesign: pending notifications (#10926) Redesign: change the filters style (#11049) Redesign: secondary actions (#11067) Redesign: assembly members page (#10992) Redesign: update default static map size to 300px (#10953) Redesign: visual placeholder cards (#11038) Redesign: fix emoji popup position (#10957) Redesign: enable REDESIGN_ENABLED on ParticipatoryProcesses (#10983) Redesign: opinion buttons (#10998) Display a disabled message button in public profile if user blocks them instead of hidding it (#10984) Redesign: confirm modal Foundation-free (#10978) Redesign: initiatives (#10646) Redesign: surveys (#10922) ...
ferblape
added a commit
that referenced
this pull request
Jun 26, 2023
* Use the component name in the sidebar title * Control when current_component is not defined * Test component name in the sidebar * Discard conferences behaviour
entantoencuanto
added a commit
that referenced
this pull request
Jun 28, 2023
* feature/redesign: Redesign: home (#10920) Remove widgets and embeds (#11096) Redesign / Complete card G cell specs (#11094) Redesign: processes assemblies metadata content blocks (#10637) Redesign: vertical margin inside the callouts (#11071) Redesign / Update package-lock (#11091) Use the component name in the sidebar title (#11088)
entantoencuanto
added a commit
that referenced
this pull request
Jun 28, 2023
* feature/redesign: Redesign: home (#10920) Remove widgets and embeds (#11096) Redesign / Complete card G cell specs (#11094) Redesign: processes assemblies metadata content blocks (#10637) Redesign: vertical margin inside the callouts (#11071) Redesign / Update package-lock (#11091) Use the component name in the sidebar title (#11088)
entantoencuanto
added a commit
that referenced
this pull request
Jun 30, 2023
…-process * feature/redesign: Redesign: display online meeting (#11075) Redesign: home menu content block (#11048) Redesign: home (#10920) Remove widgets and embeds (#11096) Redesign / Complete card G cell specs (#11094) Redesign: processes assemblies metadata content blocks (#10637) Redesign: vertical margin inside the callouts (#11071) Redesign / Update package-lock (#11091) Use the component name in the sidebar title (#11088) Redesign: layout center (#11068) Redesign: display only public users followings in following profile tab (#11051) Redesign: fix cards (#11072)
ferblape
added a commit
that referenced
this pull request
Jul 1, 2023
…11093) * Add highlighted process in menu * Integrate last activity * do not test the css * simplify markup * css tweaks * wrap metadata in cards * Redesign: fix cards (#11072) * small tweaks for process/assembly cards * remove upcoming meeting from assembly card * assembly card no longer show upcoming meeting * Redesign: display only public users followings in following profile tab (#11051) * Display only public users followings in following profile tab * Force use of redesigned profile cell * Fix followings counters to consider only users and groups and fix officialization_text * Use link for personal url in profile * Remove deprecated examples * Change expected texts * Adapt tests of follows * Add REDESIGN_PENDING skip * Add cell spec for redesigned_profile_cell * Fix spelling * Adapt tests to redesigned profile * Remove deprecated examples * Prepare profile actions buttons to use options * Add missing resend email confirmation instructions button * Display user_profile_bottom hook in redesigned profile cell * Make profile_holder redesigned profile cell public available from hook * Change styles of member_of user_profile partial * Recover test * simplify markup * add separator * Fix typo Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com> --------- Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com> Co-authored-by: Fernando Blat <fernando@blat.es> Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com> * Redesign: layout center (#11068) * simplify layout center * use cols-8 layout for public profile * span to 10 cols * Simplify code * Restore conditional * Revert "Restore conditional" This reverts commit a7661bb. * Revert "Simplify code" This reverts commit a3db3dc. * Add clarification * Use case to check conditions * Offense --------- Co-authored-by: Fernando Blat <fernando@blat.es> * Use the component name in the sidebar title (#11088) * Use the component name in the sidebar title * Control when current_component is not defined * Test component name in the sidebar * Discard conferences behaviour * Redesign / Update package-lock (#11091) * Update package lock * Update package lock in design app * Check model presence * Offenses * Offenses * Update decidim-core/app/views/layouts/decidim/header/_redesigned_menu_breadcrumb_main_dropdown.html.erb Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com> * Remove deprecated REDESIGN_PENDING comment --------- Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com> Co-authored-by: Eduardo Martínez <eduardomech@gmail.com> Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR introduces a helper called
component_nameto display the name of the component displayed or the default generic name of the module (normally present in the I18n translations).📌 Related Issues
Testing
📷 Screenshots