Skip to content

Redesign / Remove widgets and embeds#11096

Merged
ferblape merged 1 commit intofeature/redesignfrom
feature/redesign-remove-widget
Jun 27, 2023
Merged

Redesign / Remove widgets and embeds#11096
ferblape merged 1 commit intofeature/redesignfrom
feature/redesign-remove-widget

Conversation

@ferblape
Copy link
Copy Markdown
Contributor

@ferblape ferblape commented Jun 24, 2023

🎩 What? Why?

This PR removes code, routes and tests of the embeds feature, which is a feature deprecated that won't be redesigned.

📌 Related Issues

Testing

  • You shouldn't be able to see any control to embed any item.
  • The old /embed suffix that could be attached to many urls to show the embed display doesn't work

📷 Screenshots

♥️ Thank you!

@request-info
Copy link
Copy Markdown

request-info bot commented Jun 24, 2023

It seems like you did not give us much information about what you are trying to do here. We would appreciate it if you could provide us with more info about this issue/PR!

@ferblape ferblape force-pushed the feature/redesign-remove-widget branch from 9a860e9 to b401ea7 Compare June 25, 2023 03:47
@ferblape ferblape changed the title Remove widgets and embeds Redesign / Remove widgets and embeds Jun 25, 2023
@ferblape ferblape marked this pull request as ready for review June 25, 2023 04:57
@ferblape ferblape added the project: redesign Barcelona City Council contract label Jun 25, 2023
@ferblape ferblape requested a review from furilo June 25, 2023 05:00
@furilo furilo requested a review from entantoencuanto June 26, 2023 06:56
@ferblape ferblape requested a review from a team June 26, 2023 19:34
@ferblape
Copy link
Copy Markdown
Contributor Author

@decidim/product this one is mostly technical, I don't know if you want to doublecheck in staging. The thing is that there aren't any embed links anymore.

@carolromero
Copy link
Copy Markdown
Member

@ferblape ok! passing it to maintainers.

@ferblape ferblape requested a review from fblupi June 27, 2023 07:55
@ferblape ferblape merged commit 9d72cc0 into feature/redesign Jun 27, 2023
@ferblape ferblape deleted the feature/redesign-remove-widget branch June 27, 2023 12:14
entantoencuanto added a commit that referenced this pull request Jun 27, 2023
* feature/redesign:
  Remove widgets and embeds (#11096)
  Redesign / Complete card G cell specs (#11094)
  Redesign: processes assemblies metadata content blocks (#10637)
  Redesign: vertical margin inside the callouts (#11071)
  Redesign / Update package-lock  (#11091)
ferblape added a commit that referenced this pull request Jun 28, 2023
ferblape added a commit that referenced this pull request Jun 28, 2023
* add styles and layout to homepage

* add class to sections

* highlighted_initiatives

* sub_hero

* add home-section-header and add card to initiatives

* add grid-3cols to cards

* add card-g to conferences

* add card-g to assemblies

* add card-g to processes

* add header and button-show-all to the rest of the content blocks

* add grid to initiatives

* Use highlighted_meetings content block on homepage instead of deprecated upcoming_meetings

* Remove deprecated upcoming_meetings content block

* Adapt upcoming_meetings cell spec to the redesigned highlighted_meetings content block

* content-banner

* sub_hero and footer_sub_hero

* last activity

* home section

* block how to participate

* add styles to section tittle

* single process

* votings and consultations

* metrics

* how to participate

* responsive

* responsive

* revert grid

* remove unused cssClasses

* Move method to metric charts presenter root class

* Allow participatory_space_metrics_cell to display not highlighted metrics

* Define organization metrics content block and use it in registry

* add classes to html-block

* Remove deprecated content block

* Remove deprecated methods

Some method marked as deprecated are used in admin dashboard

* Adapt tests to redesign

* add border-0 to avoid separator between content-block

* remove unused cssClasses

* Allow to set a see_all_path option in meetings content block involved cells and use it for homepage meetings block

* hero aspect ratio

* responsive

* hero height

* center background image

* update the conference title

* remove heart icon

* fix locales

* update highlighted initiatives

* add background-image to content-banner and align the content

* add subtitle to button

* add icons to content banner

* add editor-conter to description

* add editor-content to sub-hero

* add border and spacing between activity-blocks

* add styles to embed videos

* styles

* fix merge

* add margin to area-chart

* add no-underline to register button

* fix test: replace card--assembly by card__grid

* order scss

* fix test: replace highlighted-processes by highlighted_processes

* lint scss

* remove unused keys

* replace subhero

* fix test

* use the card__grid class for the home content-block tests

* remove duplicate text

* add color:white to editor-content

* remove highlighted_content_banner padding

* center align the footer_sub_hero

* fix highlighted_initiatives

* Adapt upcoming meetings content block spec to highlighted meetings block

* Skip accessibility tests when redesign is not enabled

* Adapt tests

* Unify code of highlighted assemblies, conferences and initiatives home content blocks

* Update decidim-consultations/app/cells/decidim/consultations/content_blocks/highlighted_consultations/show.erb

Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>

* Use generic content block for highlighted votings in home

* Use generic content block for highlighted processes in home

* Replace html content block with redesigned version

* Use limited spaces on highlighted spaces content block

* Update selector in test

* Update method name in test

* Don't use generic limited_highlighted_spaces method for processes content block

* Join highlighted and not highlighted stats in the same container of stats content block

* add margin between the button and text. Same font-size for the texts

* Accept suggestion

Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>

* Redesign: processes assemblies metadata content blocks (#10637)

* Define a method in area presenter to include area type in name if present

* Refactor description view in processes to use a presenter

* Add description view to assemblies and link from main data content block

* Replace start_date and end_date items by date_range in process about page

* Add duration and closing date elements to assembly about page

* Normalize assemblies translations

* move style form about page to core

* Fix sanitizer on description pages to allow embedded videos

* Add tests for description pages

* Adapt triggerWarnings method used when iframes are present to redesign

* Rename metadata content blocks in participatory spaces and groups

* Define and register metadata content blocks on assemblies and processes

* Include full description in main data cell

* Remove link to about page in main data content block

* Remove description paths, actions, views and references on assemblies and participatory processes

* Skip REDESIGN_PENDING tests of description pages pending to adapt to content blocks

* Remove unused translation

* Add description attributes of metadata content blocks to ignore_unused

* add grid for metadata block

* fix style glitches on modal steps

* wrap description with a show more/less content

* Add missing translations taken fron announcement with truncation branch

* remove possible margin top of first childs

* Include purpose_of_action, internal_organisation and composition in main data of assemblies

* Fix assembly type item in extra data content block

* Fix date format

* Split assemblies metadata content block in two content blocks

* Remove date range from metadata participatory processes content block

* Extract social handler links to a content block

* Include missing content block in test

* Remove duration from assemblies dates metadata content block

* Remove unused translation

* Update decidim-assemblies/app/cells/decidim/assemblies/content_blocks/main_data_cell.rb

Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>

* Update decidim-assemblies/app/cells/decidim/assemblies/content_blocks/main_data_cell.rb

Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>

* Change endless method definitions

* Use a presented assembly in extra data content block

---------

Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>

* Redesign / Complete card G cell specs (#11094)

* Complete Cell G specs

* Cleanup specs

* Remove widgets and embeds (#11096)

* Apply feedback

---------

Co-authored-by: Eduardo Martinez Echevarria <eduardomech@gmail.com>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
Co-authored-by: Fernando Blat <fernando@blat.es>
Co-authored-by: Fran Bolívar <francisco.bolivar@nazaries.com>
Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
entantoencuanto added a commit that referenced this pull request Jun 28, 2023
* feature/redesign:
  Redesign: home (#10920)
  Remove widgets and embeds (#11096)
  Redesign / Complete card G cell specs (#11094)
  Redesign: processes assemblies metadata content blocks (#10637)
  Redesign: vertical margin inside the callouts (#11071)
  Redesign / Update package-lock  (#11091)
  Use the component name in the sidebar title (#11088)
entantoencuanto added a commit that referenced this pull request Jun 28, 2023
* feature/redesign:
  Redesign: home (#10920)
  Remove widgets and embeds (#11096)
entantoencuanto added a commit that referenced this pull request Jun 28, 2023
* feature/redesign:
  Redesign: home (#10920)
  Remove widgets and embeds (#11096)
  Redesign / Complete card G cell specs (#11094)
  Redesign: processes assemblies metadata content blocks (#10637)
  Redesign: vertical margin inside the callouts (#11071)
  Redesign / Update package-lock  (#11091)
  Use the component name in the sidebar title (#11088)
entantoencuanto added a commit that referenced this pull request Jun 30, 2023
…-process

* feature/redesign:
  Redesign: display online meeting (#11075)
  Redesign: home menu content block (#11048)
  Redesign: home (#10920)
  Remove widgets and embeds (#11096)
  Redesign / Complete card G cell specs (#11094)
  Redesign: processes assemblies metadata content blocks (#10637)
  Redesign: vertical margin inside the callouts (#11071)
  Redesign / Update package-lock  (#11091)
  Use the component name in the sidebar title (#11088)
  Redesign: layout center (#11068)
  Redesign: display only public users followings in following profile tab (#11051)
  Redesign: fix cards (#11072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants