Redesign: vertical margin inside the callouts#11071
Merged
ferblape merged 11 commits intofeature/redesignfrom Jun 26, 2023
Merged
Redesign: vertical margin inside the callouts#11071ferblape merged 11 commits intofeature/redesignfrom
ferblape merged 11 commits intofeature/redesignfrom
Conversation
furilo
approved these changes
Jun 20, 2023
…into feature/redesign-headings-callouts
Contributor
|
Ping @decidim/product |
…om/decidim/decidim into feature/redesign-headings-callouts
carolromero
approved these changes
Jun 23, 2023
Member
carolromero
left a comment
There was a problem hiding this comment.
Looks good, thanks @jorgeatgu!
Contributor
|
Sorry @fblupi I didn't notice about the failing tests. I'll ping you when they get solved |
…into feature/redesign-headings-callouts
Contributor
Author
fblupi
requested changes
Jun 26, 2023
Member
fblupi
left a comment
There was a problem hiding this comment.
A test in the admin_manages_surveys_spec.rb file is still failing. You need to fix it before approving this PR
Contributor
Author
Fixed @fblupi |
entantoencuanto
added a commit
that referenced
this pull request
Jun 28, 2023
* feature/redesign: Redesign: home (#10920) Remove widgets and embeds (#11096) Redesign / Complete card G cell specs (#11094) Redesign: processes assemblies metadata content blocks (#10637) Redesign: vertical margin inside the callouts (#11071) Redesign / Update package-lock (#11091) Use the component name in the sidebar title (#11088)
entantoencuanto
added a commit
that referenced
this pull request
Jun 28, 2023
* feature/redesign: Redesign: home (#10920) Remove widgets and embeds (#11096) Redesign / Complete card G cell specs (#11094) Redesign: processes assemblies metadata content blocks (#10637) Redesign: vertical margin inside the callouts (#11071) Redesign / Update package-lock (#11091) Use the component name in the sidebar title (#11088)
entantoencuanto
added a commit
that referenced
this pull request
Jun 30, 2023
…-process * feature/redesign: Redesign: display online meeting (#11075) Redesign: home menu content block (#11048) Redesign: home (#10920) Remove widgets and embeds (#11096) Redesign / Complete card G cell specs (#11094) Redesign: processes assemblies metadata content blocks (#10637) Redesign: vertical margin inside the callouts (#11071) Redesign / Update package-lock (#11091) Use the component name in the sidebar title (#11088) Redesign: layout center (#11068) Redesign: display only public users followings in following profile tab (#11051) Redesign: fix cards (#11072)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
<p>&<headings>: Remove vertical margin if its the only item in the callout.Add the class
editor-contentclass to the debates and budgets announcements.📌 Related Issues
Link your PR to an issue
Testing
Debate
📷 Screenshots